Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement notification delete api and permit access deleted voucher with null barcode #146

Merged
merged 9 commits into from
Oct 28, 2023
Merged

Implement notification delete api and permit access deleted voucher with null barcode #146

merged 9 commits into from
Oct 28, 2023

Conversation

inh2613
Copy link
Member

@inh2613 inh2613 commented Oct 27, 2023

PR Type

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 테스트 코드 작성
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 문서 작성

Motivation

  • 알림 삭제 기능 구현 요청
  • 삭제된 기프티콘 조회 기능 구현 요청
  • 유효기간 0일 남은 알림인 경우의 알림 메세지 수정 요청

Problem Solving

  • 삭제된 기프티콘의 경우 바코드 값을 null 변경하여 구현
  • 기프티콘 상세 조회 시 is_accessible 프로퍼티로 접근 가능 여부를 판단

To Reviewer

@inh2613 inh2613 added 🐛 bug Something isn't working 💳 Voucher 기프티콘과 관련된 라벨 📣 Notification 알람에 관련된 라벨 labels Oct 27, 2023
@inh2613 inh2613 requested a review from jinlee1703 October 27, 2023 13:13
@inh2613 inh2613 self-assigned this Oct 27, 2023
jinlee1703
jinlee1703 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@jinlee1703 jinlee1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

@inh2613 inh2613 merged commit a4bbadd into develop Oct 28, 2023
2 checks passed
@inh2613 inh2613 deleted the feat/GH-379-notification-delete branch October 28, 2023 09:36
jinlee1703 added a commit that referenced this pull request Nov 5, 2023
@jinlee1703
fix/GH-146-voucher-image-save (#38)
d69a789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinlee1703 jinlee1703 jinlee1703 approved these changes

Assignees

@inh2613 inh2613

Labels
🐛 bug Something isn't working 📣 Notification 알람에 관련된 라벨 💳 Voucher 기프티콘과 관련된 라벨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inh2613 @jinlee1703