Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to read method to handle google sign-in 500 error #144

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Change to read method to handle google sign-in 500 error #144

merged 2 commits into from
Oct 25, 2023

Conversation

inh2613
Copy link
Member

@inh2613 inh2613 commented Oct 25, 2023

PR Type

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 테스트 코드 작성
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 문서 작성

Motivation

구글 로그인 시 500에러 발생

Problem Solving

  • findByPlatformAndPlatformIdAndDeletedAtIsNull 로 변경 (기존 작업에서 누락됐었음)
  • notification message 수정 및 중복 저장 제거

To Reviewer

notification message 수정을 위한 이슈 만들기에는 너무 사소한 작업 같아서 한 브랜치에 작업하였습니다. 양해 부탁드립니다.

@inh2613 inh2613 added the 🐛 bug Something isn't working label Oct 25, 2023
@inh2613 inh2613 requested a review from jinlee1703 October 25, 2023 09:41
@inh2613 inh2613 self-assigned this Oct 25, 2023
jinlee1703
jinlee1703 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@jinlee1703 jinlee1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

@inh2613 inh2613 merged commit 3f9f86d into develop Oct 25, 2023
2 checks passed
@inh2613 inh2613 deleted the fix/GH-376-google-sign-in-duplicate-oauth-info branch October 25, 2023 11:42
jinlee1703 added a commit that referenced this pull request Nov 5, 2023
@jinlee1703
feat/GH-144-voucher-update (#41)
63b8ff0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinlee1703 jinlee1703 jinlee1703 approved these changes

Assignees

@inh2613 inh2613

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inh2613 @jinlee1703