Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement expiration notifications Allow and Deny API #143

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

inh2613
Copy link
Member

@inh2613 inh2613 commented Oct 25, 2023

PR Type

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 테스트 코드 작성
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 문서 작성

Motivation

기존 알림동의하기 관리 진행할 시, pending 처리 후 새로고침이 안됨

Problem Solving

  • user entity에서 만료 알림 수신 여부를 관리
  • 별도의 API로 만료 알림 수신 여부를 변경할 수 있도록 함

To Reviewer

요청, 응답 형식은 postman을 참고해주세요.

@inh2613 inh2613 added 🐛 bug Something isn't working 📣 Notification 알람에 관련된 라벨 labels Oct 25, 2023
@inh2613 inh2613 requested a review from jinlee1703 October 25, 2023 09:15
@inh2613 inh2613 self-assigned this Oct 25, 2023
@inh2613 inh2613 requested a review from seheon99 October 25, 2023 09:17
Copy link
Contributor

@seheon99 seheon99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

Copy link
Member

@jinlee1703 jinlee1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

* 만료 알림 수신 허용 테스트
*/
@Test
@WithMockUser(username = "이진우", roles = "USER")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P4 : 다음 번에는 roles를 우리가 정의한 role로 설정해서 해보면 한층 더 정교한(role에 따라 접근 권한이 다른 api일 수 있으니) 테스트가 될 것 같습니다.

@inh2613 inh2613 merged commit 44649b5 into develop Oct 25, 2023
2 checks passed
@inh2613 inh2613 deleted the fix/GH-374-expiration-notifications-allow-deny-api branch October 25, 2023 11:42
jinlee1703 pushed a commit that referenced this pull request Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 📣 Notification 알람에 관련된 라벨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants