Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set minimum oauth linked account #137

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Set minimum oauth linked account #137

merged 3 commits into from
Oct 24, 2023

Conversation

jinlee1703
Copy link
Member

PR Type

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 테스트 코드 작성
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 문서 작성

Motivation

  • 아래 절차를 통해 로그인을 할 수 없는 유령 계정 생성 케이스 발견
    1. Third-Party 로그인하기
    2. 내 정보 수정에서 Third-Party 계정 연동 해지
    3. 로그아웃

Problem Solving

  • Third-Party로 가입한 계정(UUID로 판별)의 경우 최소 1개 이상의 Third-Party 계정이 연동되어 있도록 로직 수정

To Reviewer

  • 없음

@jinlee1703 jinlee1703 added 🐛 bug Something isn't working 👮‍♂️ Auth 회원 및 인증에 관련된 라벨 labels Oct 24, 2023
@jinlee1703 jinlee1703 requested a review from inh2613 October 24, 2023 03:53
@jinlee1703 jinlee1703 self-assigned this Oct 24, 2023
inh2613
inh2613 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@inh2613 inh2613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinlee1703 jinlee1703 merged commit 405b00f into develop Oct 24, 2023
2 checks passed
@jinlee1703 jinlee1703 deleted the fix/GH-353-oauth-delete branch October 24, 2023 09:06
jinlee1703 pushed a commit that referenced this pull request Nov 5, 2023
@inh2613
Fix/GH-137-refresh-token-reuse-bug (#32)
bacbd4c
jinlee1703 pushed a commit that referenced this pull request Nov 5, 2023
@inh2613
Fix/GH-137-RefreshToken-Reuse-Bug (#35)
cc8e58d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inh2613 inh2613 inh2613 approved these changes

Assignees

@jinlee1703 jinlee1703

Labels
👮‍♂️ Auth 회원 및 인증에 관련된 라벨 🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinlee1703 @inh2613