Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nickname-length exception-handling logic #136

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Add nickname-length exception-handling logic #136

merged 3 commits into from
Oct 23, 2023

Conversation

jinlee1703
Copy link
Member

PR Type

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 테스트 코드 작성
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 문서 작성

Motivation

  • 회원 정보 수정 시 닉네임 길이가 12자가 넘을 경우 500 에러 바생

Problem Solving

  • 닉네임 길이에 따른 예외처리 로직 추가

To Reviewer

  • 없음

@jinlee1703 jinlee1703 added 🐛 bug Something isn't working 👮‍♂️ Auth 회원 및 인증에 관련된 라벨 labels Oct 23, 2023
@jinlee1703 jinlee1703 requested a review from inh2613 October 23, 2023 10:10
@jinlee1703 jinlee1703 self-assigned this Oct 23, 2023
inh2613
inh2613 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@inh2613 inh2613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinlee1703 jinlee1703 merged commit 00d3b92 into develop Oct 23, 2023
2 checks passed
@jinlee1703 jinlee1703 deleted the fix/GH-351-user-update branch October 23, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inh2613 inh2613 inh2613 approved these changes

Assignees

@jinlee1703 jinlee1703

Labels
👮‍♂️ Auth 회원 및 인증에 관련된 라벨 🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinlee1703 @inh2613