Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re Sign-up a user who previously left #135

Merged
merged 4 commits into from
Oct 22, 2023

Conversation

inh2613
Copy link
Member

@inh2613 inh2613 commented Oct 22, 2023

PR Type

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 테스트 코드 작성
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 문서 작성

Motivation

일반 로그인 계정으로 가입 후, 탈퇴했던 계정의 username으로는 가입이 안됐었음

Problem Solving

  • username의 unique 속성해제
  • findByUsername의 결과가 2개 이상으로 나와서 에러발생하여 findByUsernameAndDeletedIsNull메서드로 변경

To Reviewer

@inh2613 inh2613 added 🐛 bug Something isn't working 👮‍♂️ Auth 회원 및 인증에 관련된 라벨 labels Oct 22, 2023
@inh2613 inh2613 requested a review from jinlee1703 October 22, 2023 10:51
@inh2613 inh2613 self-assigned this Oct 22, 2023
Copy link
Member

@jinlee1703 jinlee1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.
예전부터 궁금했었는데 repository 메서드명을 굉장히 잘 사용하시는데, 혹시 참고하신 게 따로 있으신가요??

@inh2613
Copy link
Member Author

inh2613 commented Oct 22, 2023

참고한 자료는 딱히 없고, JPA 공부하다가 쿼리 메서드라는 것을 알게되어서 사용하게 되었습니다.

@inh2613 inh2613 merged commit 82ecbe8 into develop Oct 22, 2023
2 checks passed
@inh2613 inh2613 deleted the fix/GH-357-delete-user-re-sign-up branch October 22, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👮‍♂️ Auth 회원 및 인증에 관련된 라벨 🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants