Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement change-voucher owner to giftcard API #132

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Implement change-voucher owner to giftcard API #132

merged 5 commits into from
Oct 20, 2023

Conversation

jinlee1703
Copy link
Member

PR Type

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 테스트 코드 작성
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 문서 작성

Motivation

  • 공유하기 기능을 통한 기프티콘 양도 기능 도입 필요

Problem Solving

  • 기프티콘 소유자 변경 API 구현

To Reviewer

  • 순환참조로 인해 GiftCardService가 VoucherService가 아닌 VoucherRepository를 호출하고 있습니다.

@jinlee1703 jinlee1703 added the 💳 Voucher 기프티콘과 관련된 라벨 label Oct 20, 2023
@jinlee1703 jinlee1703 requested a review from inh2613 October 20, 2023 03:15
@jinlee1703 jinlee1703 self-assigned this Oct 20, 2023
inh2613
inh2613 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@inh2613 inh2613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinlee1703 jinlee1703 merged commit cbf12ef into develop Oct 20, 2023
2 checks passed
@jinlee1703 jinlee1703 deleted the feature/GH-345-giftcard-acquire branch October 20, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inh2613 inh2613 inh2613 approved these changes

Assignees

@jinlee1703 jinlee1703

Labels
💳 Voucher 기프티콘과 관련된 라벨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinlee1703 @inh2613