Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement read giftcard-info API #128

Merged
merged 15 commits into from
Oct 19, 2023
Merged

Implement read giftcard-info API #128

merged 15 commits into from
Oct 19, 2023

Conversation

jinlee1703
Copy link
Member

PR Type

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 테스트 코드 작성
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 문서 작성
  • 리팩토링

Motivation

  • 기프티콘 공유하기 기능을 제공하기 위해 공유하기 정보를 조회하는 기능 필요

Problem Solving

  • 공유하기 정보 조회 API 구현
  • BasicAuthenticationDecoder 구현

To Reviewer

  • Example Request, Response

    image

@jinlee1703 jinlee1703 added the 💳 Voucher 기프티콘과 관련된 라벨 label Oct 19, 2023
@jinlee1703 jinlee1703 requested a review from inh2613 October 19, 2023 05:54
@jinlee1703 jinlee1703 self-assigned this Oct 19, 2023
@jinlee1703 jinlee1703 requested a review from seheon99 October 19, 2023 05:55
seheon99
seheon99 reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@seheon99 seheon99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

inh2613
inh2613 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@inh2613 inh2613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinlee1703 jinlee1703 merged commit 54d07c2 into develop Oct 19, 2023
2 checks passed
@jinlee1703 jinlee1703 deleted the feature/GH-344-giftcard-read branch October 19, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seheon99 seheon99 seheon99 left review comments

@inh2613 inh2613 inh2613 approved these changes

Assignees

@jinlee1703 jinlee1703

Labels
💳 Voucher 기프티콘과 관련된 라벨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinlee1703 @seheon99 @inh2613