Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

서술형 커뮤니티화 #114

Merged
merged 35 commits into from
Jan 21, 2024
Merged

서술형 커뮤니티화 #114

merged 35 commits into from
Jan 21, 2024

Conversation

Kim-Hyunjo
Copy link
Member

Issue Number

close: #428

스크린샷 2023-12-10 오후 10 50 18

작업 내역

구현 내용 및 작업 했던 내역

  • 서술형 커뮤니티화 마크업, API 연결 (글 불러오기, 글 작성, 댓글 작성, 좋아요, 북마크, 댓글 좋아요 등)
  • 로그아웃 상태인 경우 처리

작업 유형

  • 신규 기능 추가
  • 버그 수정
  • 리펙토링
  • 문서 업데이트

PR 특이 사항

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • 댓글 정렬 시간 오름차순으로 해줘~~~~
  • 로그아웃시 input이 냅다 안보이게 했는데 보이게 해놓고 막는거랑 어느쪽이 더 좋을지?
  • 삭제 넣기 구찮은데 다음에 넣겠읍니다..

Copy link
Member

@kshired kshired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kim-Hyunjo 천천히 봐주세용

Comment on lines 78 to 84
e.preventDefault();
const formElement = e.target as HTMLFormElement;
const data = new FormData(formElement);
const content = data.get('post-input')?.toString();
if (!content) return;
addPost({ problemId: parseInt(id), content });
formElement.reset();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postInput이랑 거의 겹치는데 이거 공통화는 어려울까용

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음주에 보겠습니다ㅠㅠ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

singleInputValue를 submit할때에 대한 util함수를 생성해보았습니다,,

packages/service/src/utils/parseDateTime.ts Outdated Show resolved Hide resolved
@Kim-Hyunjo Kim-Hyunjo merged commit 8dfb5b7 into dev Jan 21, 2024
1 check passed
@Kim-Hyunjo Kim-Hyunjo deleted the feat/428 branch January 21, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants