Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split task file cluster-bootstrap in two: AWS+GCP #296

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Split task file cluster-bootstrap in two: AWS+GCP #296

merged 1 commit into from
Nov 27, 2024

Conversation

lilyeyes
Copy link
Contributor

@lilyeyes lilyeyes commented Nov 25, 2024 •
edited
Loading

Split task file cluster-bootstrap in two csp specific AWS, GCP files

Related ticket:
TEAM-9760 - Split task file cluster-bootstrap in two csp specific AWS, GCP files

VRs:
hanasr AWS:
hanasr_aws_test_fencing_sbd_stop_kill: http://openqaworker15.qa.suse.cz/tests/303791 (passed)
hanasr_aws_test_fencing_sbd_crash: http://openqaworker15.qa.suse.cz/tests/303799 (failed on known issue)
hanasr GCP:
hanasr_gcp_test_fencing_sbd_stop_kill: http://openqaworker15.qa.suse.cz/tests/303792 (passed)
hanasr_gcp_test_saptune_fencing_native_crash: http://openqaworker15.qa.suse.cz/tests/303800 (failed on known issue)

qesap AWS
qesap_aws_sapconf_test: http://openqaworker15.qa.suse.cz/tests/303793 (passed)
qesap_aws_fencing_native_test: http://openqaworker15.qa.suse.cz/tests/303798 (passed)
qesap GCP:
qesap_gcp_saptune_test: http://openqaworker15.qa.suse.cz/tests/303796 (passed)
qesap_gcp_sbd_test: http://openqaworker15.qa.suse.cz/tests/303797 (passed)

@lilyeyes lilyeyes marked this pull request as ready for review November 26, 2024 06:04
@badboywj
Copy link
Collaborator

LGTM, thanks

@Amrysliu
Copy link

LGTM

BillAnastasiadis
BillAnastasiadis approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@BillAnastasiadis BillAnastasiadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lpalovsky
lpalovsky approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@lpalovsky lpalovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ansible/playbooks/tasks/aws-cluster-bootstrap.yaml Outdated Show resolved Hide resolved
alvarocarvajald
alvarocarvajald approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpagot
mpagot approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilyeyes
Copy link
Contributor Author

@mpagot Thanks for the comments. I will revise code in another PR since this PR is only for splitting (what I did is 99% deleting)

@lilyeyes lilyeyes force-pushed the split-task-file-cluster-bootstrap-in-two-AWS-GCP branch from 3fd035a to 2950957 Compare November 27, 2024 02:15
@lilyeyes
Split task file cluster-bootstrap in two: AWS+GCP
f3345bc 
Split task file cluster-bootstrap in two csp specific AWS, GCP files
TEAM-9760 - Split task file cluster-bootstrap in two csp specific AWS, GCP files
@lilyeyes lilyeyes force-pushed the split-task-file-cluster-bootstrap-in-two-AWS-GCP branch from 2950957 to f3345bc Compare November 27, 2024 02:18
@lilyeyes lilyeyes marked this pull request as draft November 27, 2024 04:06
@lilyeyes
Copy link
Contributor Author

@mpagot Thanks for the comments. I will revise code in another PR since this PR is only for splitting (what I did is 99% deleting)

Since I don't have permission to merge this PR so I updated the code according to all your comments and did new VRs. Please help to review/merge.
https://openqaworker15.qa.suse.cz/tests/303934 (hanasr_aws_test_fencing_sbd_stop_kill: passed)
https://openqaworker15.qa.suse.cz/tests/304002 (hanasr_gcp_test_fencing_sbd_stop_kill: passed)
https://openqaworker15.qa.suse.cz/tests/303936 (qesap_aws_fencing_native_test: passed)
https://openqaworker15.qa.suse.cz/tests/303937 (qesap_gcp_sbd_test: passed )

@lilyeyes lilyeyes marked this pull request as ready for review November 27, 2024 06:17
mpagot
mpagot approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpagot mpagot merged commit c9d30e6 into SUSE:main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpagot mpagot mpagot approved these changes

@BillAnastasiadis BillAnastasiadis BillAnastasiadis approved these changes

@lpalovsky lpalovsky lpalovsky approved these changes

@alvarocarvajald alvarocarvajald alvarocarvajald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lilyeyes @badboywj @Amrysliu @alvarocarvajald @lpalovsky @BillAnastasiadis @mpagot