Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve CI test breaking gasnet issues #6386

Open
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

ct-clmsn
Copy link
Contributor

@ct-clmsn ct-clmsn commented Nov 10, 2023

Fixes #6385

Proposed Changes

  • modify builders to use gasnet-mpi
  • modify the hpxrun script to use mpiexec when testing gasnet-mpi
  • update the gasnet environment logic to enable or disable gasnet

Any background context you want to provide?

the gasnet parcelport was merged into hpx and had started causing other parcelport tests to silently fail

Checklist

Not all points below apply to all pull requests.

  • I have added a new feature and have added tests to go along with it.
  • I have fixed a bug and have added a regression test.

@ct-clmsn ct-clmsn requested a review from hkaiser as a code owner November 10, 2023 02:15
Copy link

codacy-production bot commented Nov 10, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.07%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5ffdfbe) 193075 164320 85.11%
Head commit (8877fed) 190055 (-3020) 161877 (-2443) 85.17% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6386) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@ct-clmsn ct-clmsn changed the title effort to resolve build breaking gasnet issues resolve CI test breaking gasnet issues Nov 10, 2023
@Pansysk75
Copy link
Member

retest lsu

@Pansysk75
Copy link
Member

retest

@hkaiser
Copy link
Member

hkaiser commented Jan 14, 2024

@Pansysk75, @ct-clmsn: what is the state of this PR? Did we ever manage to get the gasnet parcelport working properly?

@ct-clmsn
Copy link
Contributor Author

@hkaiser I've had issues accessing the execution logs when the application fails runtime checks. I'll be pushing to complete this on a separate cluster at the top of the week.

@hkaiser
Copy link
Member

hkaiser commented Jan 14, 2024

@hkaiser I've had issues accessing the execution logs when the application fails runtime checks. I'll be pushing to complete this on a separate cluster at the top of the week.

Yes, the CSCS CDash is a bit unreliable, currently. We're in the process of moving it to Rostam.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.44%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5ffdfbe) 0 0 84.57%
Head commit (b5694fc) 189565 (+189565) 161149 (+161149) 85.01% (+0.44%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6386) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@hkaiser
Copy link
Member

hkaiser commented Apr 28, 2024

@ct-clmsn could you please rebase this onto master? This will give us an understanding of what works (and what doesn't). Thanks!

@ct-clmsn
Copy link
Contributor Author

@hkaiser will do; currently working with @constracktor on debugging this branch

@hkaiser
Copy link
Member

hkaiser commented May 3, 2024

@hkaiser will do; currently working with @constracktor on debugging this branch

Thanks. I'll leave this PR for now on track for the upcomming V1.10.0 release.

@hkaiser hkaiser modified the milestones: 1.10.0, 1.11.0 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gasnet parcelport and parcelport test failures
3 participants