Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving hpx::threads::run_as_xxx to namespace hpx #6349

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Sep 14, 2023

  • run_as_os_thread
  • run_as_hpx_thread

@hkaiser hkaiser changed the title Moving hpx::threads::run_as_hpx_thread to namespace hpx Moving hpx::threads::run_as_xxx to namespace hpx Sep 14, 2023
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for c8ea2c71 88.89%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c8ea2c7) Report Missing Report Missing Report Missing
Head commit (496f4ba) 188353 160205 85.06%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6349) 9 8 88.89%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@hkaiser
Copy link
Member Author

hkaiser commented Sep 25, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 25, 2023
6344: uninitialized_relocate w/ type_support primitive r=hkaiser a=isidorostsa

This PR replaces the `type_support::uninitialized_relocate` with a primitive version for uninitialized relocation, named `uninitialized_relocate_n_primitive`. This is used by the parallel and sequenced versions of `algorithms::uninitialized_relocate`.

In contrast to the previous attempt of implementing the relocation functions, #6314, this does not place the primitive in `transfer.hpp`, which is in the `algorithms` module, nor does it modify `loop.hpp` to add the specific exception handling method required by `uninitialized_relocate`. 

The goal of keeping a primitive in type support, which is relatively low level in terms of dependencies, is to use it in the higher level `small_vector` and other data structures. 

6348: Adding --exclusive to launching tests on rostam r=hkaiser a=hkaiser



6349: Moving hpx::threads::run_as_xxx to namespace hpx r=hkaiser a=hkaiser

- run_as_os_thread
- run_as_hpx_thread

Co-authored-by: isidorostsa <[email protected]>
Co-authored-by: Hartmut Kaiser <[email protected]>
@bors
Copy link

bors bot commented Sep 25, 2023

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

Response status code: 422
{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@hkaiser hkaiser merged commit 17ad7b6 into master Sep 25, 2023
18 checks passed
@hkaiser hkaiser deleted the run_as_hpx_thread branch September 25, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant