-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage testing on Jenkins #6339
Conversation
Please ignore the cmake formatting issue, that one has trickled through from master. |
retest lsu |
9040f9c
to
d5db114
Compare
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
13d6f74
to
31c36e4
Compare
31c36e4
to
2b3fdde
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Finally this worked :) I will disable this guy, we don't need a comment. I'll add the ReadMe badge as well, and check whether I forgot to include some part of HPX in the build. Currently, it runs for every PR, which takes 2 to 3 hours on Rostam (because it builds and runs all tests). I think that's fine for now, but we could get away only running it on master, to save resources. Also, currently, it reports as failed if some build/run failed, but it will intentionally still attempt to get the coverage results. |
fda306a
to
610f270
Compare
@hkaiser This is ready to merge, the only caveat being that things like APEX and CUDA (and probably others) aren't included in the tests that are currently being ran, so those parts of the codebase might not show up as "covered" by tests. Same goes for compile time tests. I suggest merging this first so that we can a few runs and thus get a better image in the dashboard. We can tweak it later if needed. Oh, also @hkaiser you'll need to disable the commenting because you are the admin in Codacy. It's in the settings tab, under "Integrations". Thanks! |
Thanks @Pansysk75! This is great.
Should we really disable the comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
bors merge |
6339: Add coverage testing on Jenkins r=hkaiser a=Pansysk75 Runs coverage tests on Jenkins, and uploads results to Codacy. Relies on fetching `grcov` utility. Co-authored-by: Panos Syskakis <[email protected]>
My pleasure :))
We can give them a chance, I don't mind at all. You can always toggle them directly from the dashboard. |
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Runs coverage tests on Jenkins, and uploads results to Codacy.
Relies on fetching
grcov
utility.