Simd Find #6302
Open
Simd Find #6302
+24
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johan511
requested review from
aurianer,
msimberg,
biddisco and
hkaiser
as code owners
hkaiser
reviewed
Aug 5, 2023
| @@ -34,8 +34,7 @@ namespace hpx::parallel::detail { | |||
| sequential_find_t<ExPolicy>, Iterator first, Sentinel last, | |||
| T const& value, Proj proj = Proj()) | |||
| { | |||
| return util::loop_pred< | |||
| std::decay_t<hpx::execution::sequenced_policy>>( | |||
| return util::loop_pred<ExPolicy>( | |||
There was a problem hiding this comment.
Could you add static_assert verifying that ExPolicy is actually a sequential policy?
There was a problem hiding this comment.
Change had been made so sequential_find_t can accept sequential and unsequential execution policies. Do you want me to rather use static_assert(is_seq || is_unseq) ?
libs/core/algorithms/include/hpx/parallel/unseq/simd_helpers.hpp
Outdated
Show resolved
Hide resolved
| /* | ||
| Compiler and Hardware should also support vector operations for IterDiff, | ||
| else we see slower performance when compared to sequential version | ||
| */ |
There was a problem hiding this comment.
What does this comment mean? Should that requirement be somehow enforced?
There was a problem hiding this comment.
As discussed previously, changing data types can lead to vectorization being broken. I wanted to leave a note for the future regarding it. Use perf regression tests might not be the best way to do this as they often seem to have lot of variance in them.
There was a problem hiding this comment.
Well, a comment doesn't help with this, does it? I think setting up performance tests would be the better option. @Pansysk75 can help with that.
There was a problem hiding this comment.
There was a problem hiding this comment.
Well, I thought we could add it to our performance tests.
There was a problem hiding this comment.
added it in a separate PR
libs/core/algorithms/tests/unit/algorithms/util/test_simd_helpers.cpp
Outdated
Show resolved
Hide resolved
|
|
Nice! |
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
|
@Johan511 could you please fix the reported clang-format issues as well? |
There is one loop yet to be vectorized, once that's done vectorization should be enabled for parallel case too. We can merge after that. |
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
|
@hkaiser the unseq_first_n function has been changed a bit, the the function now takes iterator as input instead of value, this does not break vectorization. |
Signed-off-by: Hari Hara Naveen S <[email protected]>
Signed-off-by: Hari Hara Naveen S <[email protected]> changing test according to change made to helper Signed-off-by: Hari Hara Naveen S <[email protected]>
Signed-off-by: Hari Hara Naveen S <[email protected]> unseq Signed-off-by: Hari Hara Naveen S <[email protected]>
…for function call deduction) Signed-off-by: Hari Hara Naveen S <[email protected]>
Signed-off-by: Hari Hara Naveen S <[email protected]>
Signed-off-by: Hari Hara Naveen S <[email protected]> fixed expolicy not accepting par_unseq Signed-off-by: Hari Hara Naveen S <[email protected]> cleanup changes Signed-off-by: Hari Hara Naveen S <[email protected]> fixing missing concept header Signed-off-by: Hari Hara Naveen S <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using simd-helpers (from #6286 ) to add vectorization to stl algorithms