fix: 페이지네이션 cursor 버그 수정 #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khs960616
approved these changes
Oct 18, 2023
Comment on lines
+10
to
+14
| @AllArgsConstructor | ||
| @NoArgsConstructor | ||
| public class GetPostReqDto { | ||
| private Long boardId; | ||
| private Long cursor; | ||
| private Long cursor = -1L; |
There was a problem hiding this comment.
DTO에 default value를 주기 위해서는 @ModelAttribute와 해당 어노테이션들이 추가되어야하나요?
There was a problem hiding this comment.
-
ModelAttribute는 가독성을 위해 명시 해준 것입니다.(안써도 동작은 합니다)
-
입력받지 않아도 null이 아닌 디폴트값으로 초기화 하기 위해서는 기본생성자가 필요합니다.
추가로 테스트코드에서 dto값 세팅을 위해 Builder가 필요했습니다. 하지만 Bulider를 사용하기 위해서는 기본생성자 사용 시 매개변수가 있는 생성자가 반드시 필요하기 때문에 해당 어노테이션들을 클래스에 추가했습니다
YongsHub
approved these changes
Oct 19, 2023
moonn6pence
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
구분
주요 변경점
스크린샷
기타