test: 게시글 쓰기 단위 테스트 코드 구현 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonn6pence
approved these changes
Oct 18, 2023
jjuny0310
force-pushed
the
test/write-post-#169
branch
from
1648f8e to
118a094
Compare
khs960616
approved these changes
Oct 18, 2023
YongsHub
approved these changes
Oct 19, 2023
| @@ -18,7 +18,7 @@ public class BoardService { | |||
|
|
|||
| @Transactional(readOnly = true) | |||
| public GetBoardResDto findBoards() { | |||
| List<Board> boards = boardRepository.findAll(); | |||
| List<Board> boards = boardRepository.findAllByUsedBoardTrue(); | |||
There was a problem hiding this comment.
제가 생각했을때는 True없이
boardRepository.findAllByUsedBoard();메서드 네이밍이 여기까지만 와도 이해가 잘 되는 것 같아요
There was a problem hiding this comment.
좋은 의견 감사합니다.
메서드 네이밍 규칙에 True를 사용한 이유는 UsedBoard = True라는 조건을 걸어주기 위해서입니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
구분
주요 변경점
스크린샷
기타