feat: 마이프로필 및 리크루트 데이터포맷 수정 #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonn6pence
approved these changes
Sep 20, 2023
|
|
||
| recruitPages = recruitRepository.findMemberJoinRecruitWithCursorAndPageable(memberId, getRecruitsReqDto.getCursor(), pageable); | ||
| } else { | ||
| recruitPages = recruitRepository.findRecruitByGetRecruitsReqDto(getRecruitsReqDto, pageable); |
There was a problem hiding this comment.
recruitRepository.findMemberJoinRecruitWithCursorAndPageable(memberId, getRecruitsReqDto.getCursor(), pageable) 에서는 커서를 꺼내서 파라미터를 넣어주는 여기서는 그렇게 안하네여?
There was a problem hiding this comment.
마이프로필쪽 api라 아직 확정되진 않았습니다. 다음 pr때 프론트랑 연동하면서 작업방향 정해지면 수정될 수 있습니다.
|
|
||
| private BooleanExpression recruitIdLtThanCursor(Long cursor) { | ||
| return ((cursor != null) && (cursor != -1)) ? recruit.id.lt(cursor) : null; | ||
| } |
There was a problem hiding this comment.
if (cursor == null) return null;
if (cursor == -1) return null;
return recruit.id.lt(cursor);가 낫지 않을까요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
구분
주요 변경점
스크린샷
기타