Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYNEXT-1325 Add new swimlane for audio livesteams #536

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mutaben
Copy link
Contributor

@mutaben mutaben commented Jan 27, 2025

Description

For the implementation of PAC audio, this PR implements the new audio livestreams swimlane in the new page.
It shows a horizontal swimlane with square images for each radio channel logo.

Screenshot showing new radios swimlane

Changes Made

  • Add a new case liveAudioSquaredSwimlane in the SectionLayout enum
  • Return this case from the PageViewModel.layout when the mediaType is AUDIO for the contentSection
  • Call the already defined radioLivestreams(for: contentSection.vendor, contentProviders: .all) endpoint for the publisher
  • Add a new layout with a new cell (LiveRadioSquaredCell and LiveRadioSquaredCellSize)
  • Detect the new case and propagate the right calls (Content.title, Content. publisher(...), PageViewController.layoutSection(...), PageViewController.MediaCell.body)

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben added the improvement Feature or update (issue and PR) - release notes section label Jan 27, 2025
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1325-predefined-section-square January 27, 2025 12:31 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1325-predefined-section-square January 27, 2025 12:31 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1325-predefined-section-square January 27, 2025 23:02 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1325-predefined-section-square January 27, 2025 23:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants