Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: clean untracked files when an error occurred #482

Merged
merged 1 commit into from
May 19, 2024
Merged

Conversation

pyby
Copy link
Member

@pyby pyby commented May 18, 2024

Description

When Xcode 15 pushed a build phases reorder (#374) to have the custom icons, a risk reappeared again to not have a clean repository during a build issue.

The issue came again because of a tvOS build issue: https://github.com/SRGSSR/playsrg-apple/deployments/playsrg-tvos-nightly%2BPLAYRTS-5527-swimlane-link-to-micropage

The copied original application icons are not removed:

16:25:53   Uncommitted changes:
16:25:53   ?? OriginalAppIcon.appiconset/
16:25:53   ?? OriginalAppStoreTVIcon.appiconset/
16:25:53   ?? OriginalTVAppIcon.appiconset/

This PR proposes to force a full clean if an error occurred, including cache and untracked files like the last-#{service}#{platform}nightlies-success-git-commit-hash.txt files.

Changes Made

  • Update Fastfile error handles, to not skip git clean during the reset step.

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@pyby pyby added the CI CI workflow improvement or update (issue and PR) - release notes section label May 18, 2024
@pyby pyby requested a review from mutaben May 18, 2024 22:57
@pyby pyby enabled auto-merge May 18, 2024 22:58
@pyby pyby added this pull request to the merge queue May 19, 2024
Merged via the queue into develop with commit f5fa4c5 May 19, 2024
1 check passed
@pyby pyby deleted the feature/ci-update branch May 19, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI workflow improvement or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants