CI: clean untracked files when an error occurred #482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Xcode 15 pushed a build phases reorder (#374) to have the custom icons, a risk reappeared again to not have a clean repository during a build issue.
The issue came again because of a tvOS build issue: https://github.com/SRGSSR/playsrg-apple/deployments/playsrg-tvos-nightly%2BPLAYRTS-5527-swimlane-link-to-micropage
The copied original application icons are not removed:
This PR proposes to force a full clean if an error occurred, including cache and untracked files like the
last-#{service}#{platform}nightlies-success-git-commit-hash.txt
files.Changes Made
Fastfile
error handles, to not skip git clean during the reset step.Checklist