Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design system (PLAYRTS-5514) #468

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

pyby
Copy link
Member

@pyby pyby commented May 2, 2024

Description

SRGAppearance is updated with latest design system fonts and colors.
https://github.com/SRGSSR/srgappearance-apple

The grayD2 color is quite more brightness, and update reading with a better contrast.

Changes Made

  • Update SRGAppearance to 5.2.2. version.
    • Fonts:
      • Update iOS SRGFontStyleH2 to regular bold.
      • Update iOS SRGFontStyleSubtitle1 to regular weight.
      • Update tvOS SRGFontStyleSubtitle1 to regular weight.
  • Gray colors: Update grayC7 color to grayD2 (grayC7 is deprecated).

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have reviewed the contribution guidelines.

@pyby pyby added the improvement Feature or update (issue and PR) - release notes section label May 2, 2024
@pyby pyby changed the title Update design system Update design system (PLAYRTS-5514) May 2, 2024
@pyby pyby marked this pull request as ready for review May 2, 2024 23:20
@pyby pyby requested a review from mutaben May 3, 2024 10:14
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+design-system-update May 3, 2024 10:21 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+design-system-update May 3, 2024 10:22 Inactive
@pyby pyby added this pull request to the merge queue May 6, 2024
Merged via the queue into develop with commit 243abae May 6, 2024
3 checks passed
@pyby pyby deleted the feature/design-system-update branch May 6, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants