Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate build and preview to vite #4

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

jboix
Copy link
Contributor

@jboix jboix commented Apr 30, 2024

Description

Resolves #3 by migratig both the preview mode and the build to vite.

Changes Made

  • Moved rollup configuration to a vite configuration file.
  • Added a specific vite config file for the lib build that output both a cjs and an es bundle.
  • Disabled default vite esbuild in favor of babel.
  • Update all plugins and templates with the new configuration.

Checklist

  • I have followed the project's style and contribution guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.

Copy link

github-actions bot commented Apr 30, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 100% 93 / 93
🔵 Statements 100% 93 / 93
🔵 Functions 85.71% 6 / 7
🔵 Branches 88.88% 8 / 9
File CoverageNo changed files found.
Generated in workflow #22

@jboix jboix force-pushed the feat/vite-migration branch from 1e0aef6 to 293257f Compare April 30, 2024 13:58
@jboix jboix self-assigned this Apr 30, 2024
@jboix jboix force-pushed the feat/vite-migration branch from 293257f to a64ff15 Compare April 30, 2024 15:16
Copy link

github-actions bot commented Apr 30, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-02 14:56 UTC

Resolves #3 by migratig both the preview mode and the build to vite.

- Moved rollup configuration to a vite configuration file.
- Added a specific vite config file for the lib build that output both a cjs and an es bundle.
- Disabled default vite esbuild in favor of babel.
- Update all plugins and templates with the new configuration.
@jboix jboix force-pushed the feat/vite-migration branch from a64ff15 to d8d259c Compare April 30, 2024 15:18
@jboix jboix requested a review from amtins April 30, 2024 15:19
@jboix jboix marked this pull request as ready for review April 30, 2024 15:19
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@jboix jboix added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 1877dfa May 2, 2024
4 checks passed
@jboix jboix deleted the feat/vite-migration branch May 2, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Migrate preview mode from parcel to vite
2 participants