fix: expose version on existing plugins and components #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates create script template to include the version of the generated component or plugin.
Expose the component version by adding a `VERSION` property to the constructor, to
retrieve the version of the component on a given player simply do:
```javascript
// Retrieve the player
const player = document.getElementsByTagName('video')[0].parentElement.player;
// Print the component version
console.log(player.SkipButton.constructor.VERSION);
```
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
|
Expose the plugin version by adding a static getter `VERSION` to all plugins and
components. To retrieve the version of the component on a given player simply do:
```javascript
// Retrieve the player
const player = document.getElementsByTagName('video')[0].parentElement.player;
// Print the component version
console.log(player.pillarboxPlaylist().version());
```
jboix
force-pushed
the
fix/expose-version
branch
from
475d934 to
1e07832
Compare
amtins
reviewed
Aug 28, 2024
Comment on lines
+78
to
+81
|
|
||
| static get VERSION() { | ||
| return version; | ||
| } |
|
🎉 This PR is included in version @srgssr/pillarbox-playlist-v2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @srgssr/skip-button-v1.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposes the version in the package.json of each existing plugin and component. Modified the create script template so that the
VERSIONis automatically added on every new package.Retrieve the version of a component:
Retrieve the version of a plugin:
Changes Made
VERSIONproperty to the constructor.VERSIONproperty to the constructor.Checklist