feat(playlist-plugin): introduce repeat one mode #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jboix
force-pushed
the
feat/repeat-one
branch
2 times, most recently
from
83d6619 to
0ccacac
Compare
amtins
reviewed
Jul 9, 2024
- Introduced a new "repeat one" mode to the playlist plugin. - Modified the UI to include a toggle button that cycles through three modes: no repeat, repeat all, and repeat one. BREAKING CHANGE: - Changed the API to toggle the repeat mode and the initialization options. - The repeat mode is no longer a boolean. It is now a number representing each mode (0: no repeat, 1: repeat all, 2: repeat one).
Updated the JSDoc type reference for the `Button` component to the correct path in the video.js library.
|
🎉 This PR is included in version @srgssr/pillarbox-playlist-v2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #19 by introducing a new "repeat one" mode to the playlist plugin.
The UI has been modified to include a toggle button that cycles through three modes: no repeat, repeat all, and repeat one. See the following example:
repeat-toggle-demo.mov
Changes Made
BREAKING CHANGE:
Checklist