Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initialize pillarbox web suite with plugin scaffolding #1

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

jboix
Copy link
Contributor

@jboix jboix commented Apr 22, 2024

Description

Sets up the foundational structure for the Pillarbox Web Suite, providing an npm workspace with customizable plugins for pillarbox-web.

Changes Made

  • Configured package.json with necessary dependencies and workspace definitions for plugins.
  • Included scripts for creating plugins (create:plugin) leveraging plop configurations.
  • Set up ESLint and StyleLint for code quality, and Jest for testing.
  • Integrated Rollup and Babel for building plugins.
  • Utilized Husky to enforce linting pre-commits to maintain conventional commits standard.

Checklist

  • I have followed the project's style and contribution guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.

@jboix jboix requested a review from amtins April 22, 2024 13:28
@jboix jboix self-assigned this Apr 22, 2024
@jboix jboix force-pushed the feat/create-plugin branch from 46d7fcf to 591c23b Compare April 22, 2024 13:29
@jboix jboix changed the title feat: initialize pillarbox web suite with plugint scaffolding feat: initialize pillarbox web suite with plugin scaffolding Apr 22, 2024
@jboix jboix force-pushed the feat/create-plugin branch 3 times, most recently from d3a8b80 to 6edf6c0 Compare April 22, 2024 14:41
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
@jboix jboix force-pushed the feat/create-plugin branch from 6edf6c0 to 9f79e31 Compare April 23, 2024 15:35
@jboix jboix requested a review from amtins April 23, 2024 15:37
Sets up the foundational structure for the Pillarbox Web Suite, providing an npm workspace with
customizable plugins for pillarbox-web. Key features include:

- Configured `package.json` with necessary dependencies and workspace definitions for plugins.
- Included scripts for creating plugins (`create:plugin`) leveraging plop configurations.
- Set up ESLint and StyleLint for code quality, and Jest for testing.
- Integrated Rollup and Babel for building plugins.
- Utilized Husky to enforce linting pre-commits to maintain conventional commits standard.
@jboix jboix force-pushed the feat/create-plugin branch from 9f79e31 to a40b630 Compare April 23, 2024 15:44
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jboix jboix added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit 57cc5c9 Apr 24, 2024
1 check passed
@jboix jboix deleted the feat/create-plugin branch April 24, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants