-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initialize pillarbox web suite with plugin scaffolding #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jboix
force-pushed
the
feat/create-plugin
branch
from
April 22, 2024 13:29
46d7fcf
to
591c23b
Compare
jboix
changed the title
feat: initialize pillarbox web suite with plugint scaffolding
feat: initialize pillarbox web suite with plugin scaffolding
Apr 22, 2024
jboix
force-pushed
the
feat/create-plugin
branch
3 times, most recently
from
April 22, 2024 14:41
d3a8b80
to
6edf6c0
Compare
amtins
reviewed
Apr 23, 2024
amtins
reviewed
Apr 23, 2024
amtins
reviewed
Apr 23, 2024
amtins
reviewed
Apr 23, 2024
amtins
reviewed
Apr 23, 2024
jboix
force-pushed
the
feat/create-plugin
branch
from
April 23, 2024 15:35
6edf6c0
to
9f79e31
Compare
Sets up the foundational structure for the Pillarbox Web Suite, providing an npm workspace with customizable plugins for pillarbox-web. Key features include: - Configured `package.json` with necessary dependencies and workspace definitions for plugins. - Included scripts for creating plugins (`create:plugin`) leveraging plop configurations. - Set up ESLint and StyleLint for code quality, and Jest for testing. - Integrated Rollup and Babel for building plugins. - Utilized Husky to enforce linting pre-commits to maintain conventional commits standard.
jboix
force-pushed
the
feat/create-plugin
branch
from
April 23, 2024 15:44
9f79e31
to
a40b630
Compare
amtins
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets up the foundational structure for the Pillarbox Web Suite, providing an npm workspace with customizable plugins for pillarbox-web.
Changes Made
package.json
with necessary dependencies and workspace definitions for plugins.create:plugin
) leveraging plop configurations.Checklist