Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Gradle scripts #840

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Improve Gradle scripts #840

merged 1 commit into from
Dec 19, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Dec 19, 2024

Pull request

Description

Small tweaks to Gradle scripts.

Changes made

  • Use Gradle lazy API. Replace calls to create by register. The former immediately creates and configures the object, the latter only does it when needed.
  • Only keep English resources in demo applications, since they are not translated anyway. This should help reduce the size of the final application.
  • Only creates the nightly flavor on CI.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this Dec 19, 2024
@MGaetan89 MGaetan89 added the enhancement New feature or request label Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

Code Coverage

Overall Project 52.09% -0.08% 🟢
Files changed 0% 🟢

Module Coverage
Kover Gradle Plugin XML report for :plugins 7.19% -1.63% 🟢
Files
Module File Coverage
Kover Gradle Plugin XML report for :plugins PillarboxAndroidApplicationPlugin.kt 0% -11.11% 🟢

@MGaetan89 MGaetan89 requested a review from StaehliJ December 19, 2024 08:01
@StaehliJ StaehliJ added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 9aa8f3c Dec 19, 2024
9 checks passed
@StaehliJ StaehliJ deleted the optimize_gradle branch December 19, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants