-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve accessibility in "Showcases" and on the player #821
Conversation
Code Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We should remove Overlay text from TalkBack.
- TalkBack in French say "2 metres 12" instead of a time.
- The toggle controls text should be more explicite. But it is better than before.
- When double drag in TalkBack, the controls are hide but nothing tells user in has been hidden and nothing tells what to do next.
|
2dac488
to
c51a6ab
Compare
- Don't speak out metrics overlay. - Increase the height of the slider. - Speak out the slider progress as a percentage. - Add state label to the player control view.
130fe0c
to
cbb5816
Compare
Done ✅
Changed to speak out the progress in percentage instead ✅
Added an accessibility label to describe the state of the controls ("Controls visible"/"Controls hidden") ✅
I'll look into this tomorrow ⏳
Done ✅
Done ✅
Done ✅ |
Android provides dedicated volume settings for TalkBack and Media. Maybe we should just let the user/system handle that, instead of trying to manage it ourselves. What do you think? |
Pull request
Description
This improves accessibility in the "Showcases" section and on the player.
Changes made
PillarboxSlider
when TalkBack is enabled, i.e.:build_windows.yml
workflow. This action differentiates cache by platform, so this was unnecessary since we never store cache for Windows builds.Checklist