Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility in "Showcases" and on the player #821

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Dec 6, 2024

Pull request

Description

This improves accessibility in the "Showcases" section and on the player.

Changes made

  • Adjust PillarboxSlider when TalkBack is enabled, i.e.:
    • Enforce non-compact mode.
    • Add vertical padding.
    • Add progress information.
  • Migrate player settings to Material 3 Bottom Sheet (instead of Material Navigation Bottom Sheet). The former provides better accessibility support.
  • Remove Gradle cache support in the build_windows.yml workflow. This action differentiates cache by platform, so this was unnecessary since we never store cache for Windows builds.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 linked an issue Dec 6, 2024 that may be closed by this pull request
1 task
@MGaetan89 MGaetan89 self-assigned this Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Code Coverage

Overall Project 48.65% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 requested a review from StaehliJ December 9, 2024 08:44
Copy link
Contributor

@StaehliJ StaehliJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We should remove Overlay text from TalkBack.
  • TalkBack in French say "2 metres 12" instead of a time.
  • The toggle controls text should be more explicite. But it is better than before.
  • When double drag in TalkBack, the controls are hide but nothing tells user in has been hidden and nothing tells what to do next.

@MGaetan89
Copy link
Member Author

MGaetan89 commented Dec 10, 2024

  • Check if we should lower media volume when TalkBack speaks
  • Replace the emoji name with the media type
  • Replace URN with comment in DemoItem description
  • Increase slider height

- Don't speak out metrics overlay.
- Increase the height of the slider.
- Speak out the slider progress as a percentage.
- Add state label to the player control view.
@MGaetan89
Copy link
Member Author

MGaetan89 commented Dec 10, 2024

  • We should remove Overlay text from TalkBack.

Done ✅

  • TalkBack in French say "2 metres 12" instead of a time.

Changed to speak out the progress in percentage instead ✅

  • The toggle controls text should be more explicite. But it is better than before.

Added an accessibility label to describe the state of the controls ("Controls visible"/"Controls hidden") ✅

  • When double drag in TalkBack, the controls are hide but nothing tells user in has been hidden and nothing tells what to do next.

I'll look into this tomorrow ⏳
We're using Compose's toggleable Modifier, so accessibility should already be set up properly ✅

  • Check if we should lower media volume when TalkBack speaks

I'll look into this tomorrow ⏳

  • Replace the emoji name with the media type

Done ✅

  • Replace URN with comment in DemoItem description

Done ✅

  • Increase slider height

Done ✅

pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
pillarbox-demo-shared/src/main/res/values/strings.xml Dismissed Show dismissed Hide dismissed
@MGaetan89
Copy link
Member Author

  • Check if we should lower media volume when TalkBack speaks

I'll look into this tomorrow ⏳

Android provides dedicated volume settings for TalkBack and Media. Maybe we should just let the user/system handle that, instead of trying to manage it ourselves. What do you think?
https://support.google.com/accessibility/android/answer/6283655?hl=en#:~:text=Change%20the%20volume%20for%20TalkBack

Base automatically changed from 803-accessibility to main December 12, 2024 05:49
@MGaetan89 MGaetan89 added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit e01699c Dec 12, 2024
9 checks passed
@MGaetan89 MGaetan89 deleted the 803-accessibility_2 branch December 12, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Accessibility
2 participants