Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: use runUntilPendingCommandsAreFullyHandled in CommandersActTrackerIntegrationTest #598

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Fix: use runUntilPendingCommandsAreFullyHandled in CommandersActTrackerIntegrationTest #598

merged 2 commits into from
Jun 24, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jun 21, 2024 •
edited
Loading

Pull request

Description

This commit replaces playUntilStartOfMediaItem with runUntilPendingCommandsAreFullyHandled in the CommandersActTrackerIntegrationTest file.

Changes made

  • Switch from playUntilStartOfMediaItem to runUntilPendingCommandsAreFullyHandled in CommandersActTrackerIntegrationTest.
  • Try to enable two @Ignored tests in ComScoreTrackerIntegrationTest.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

MGaetan89 added 2 commits June 21, 2024 16:43
@MGaetan89
Fix: use runUntilPendingCommandsAreFullyHandled in CommandersActTra…
6dbe016 
…ckerIntegrationTest

This commit replaces `playUntilStartOfMediaItem` with `run
UntilPendingCommandsAreFullyHandled` in the CommandersActTrackerIntegrationTest.
@MGaetan89
Enable ComScore integration tests for live content
2101a58 
This commit removes the `@Ignore` annotations from the ComScore integration tests for live content, enabling them to run
 as part of the test suite. This assumes that a live DVR is now available outside of Switzerland for testing purposes.
@MGaetan89 MGaetan89 added this to the QoS milestone Jun 21, 2024
@MGaetan89 MGaetan89 self-assigned this Jun 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 21, 2024 •
edited
Loading

Code Coverage

Overall Project 52.33% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 requested a review from StaehliJ June 21, 2024 14:59
@MGaetan89 MGaetan89 marked this pull request as ready for review June 21, 2024 14:59
@StaehliJ
Copy link
Contributor

Doesn't no why in the past tests passes and now no more. Hint: stream provider changes some days ago.

@StaehliJ StaehliJ merged commit 93188ea into qos Jun 24, 2024
16 checks passed
@StaehliJ StaehliJ deleted the fix_tests branch June 24, 2024 06:38
This was referenced Jun 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ Awaiting requested review from StaehliJ

Assignees

@MGaetan89 MGaetan89

Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
QoS
Development

Successfully merging this pull request may close these issues.
2 participants
@MGaetan89 @StaehliJ