Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom blocked segments #539

Merged
merged 3 commits into from
May 10, 2024
Merged

Custom blocked segments #539

merged 3 commits into from
May 10, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented May 8, 2024

Pull request

Description

The goal of this PR is to add some edge cases sample for BlockedTimeRange. The edge cases covered are

  1. Overlapping of BlockedTimeRange
  2. BlockTimeRange included in another one.
  3. BlockTimeRange are present at the start and one to the end of the media.

Changes made

  • BlockedTimeRange at the end of the media seek to the end of the media and so the last frame of the content will be visible.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ added the enhancement New feature or request label May 8, 2024
@StaehliJ StaehliJ requested a review from MGaetan89 May 8, 2024 14:49
Copy link

github-actions bot commented May 8, 2024

Code Coverage

Overall Project 48.64% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-player 49.3% 🟢
Files
Module File Coverage
:pillarbox-player TimeRangeTracker.kt 92.84% 🟢

@MGaetan89 MGaetan89 added this to the Demo milestone May 10, 2024
@MGaetan89 MGaetan89 enabled auto-merge May 10, 2024 09:24
@MGaetan89 MGaetan89 added this pull request to the merge queue May 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 516a25f May 10, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the custom-blocked-segments branch May 10, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants