Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usages of MediaItemUrn with SRGMediaItemBuilder #537

Merged
merged 1 commit into from
May 13, 2024
Merged

Replace usages of MediaItemUrn with SRGMediaItemBuilder #537

merged 1 commit into from
May 13, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented May 8, 2024 •
edited
Loading

Pull request

Description

MediaItemUrn was deprecated in Pillarbox 2.0.0, in favour of SRGMediaItemBuilder. This PR migrates the remaining MediaItemUrn in the project.

Changes made

  • Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue May 8, 2024 that may be closed by this pull request
Replace deprecated usages of MediaItemUrn with SRGMediaItemBuilder #536
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Code Coverage

Overall Project 48.45% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 force-pushed the 536-replace-deprecated-usages-of-mediaitemurn-with-srgmediaitembuilder branch from 5f25fae to eb280f5 Compare May 10, 2024 09:52
jboix
jboix approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@jboix jboix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MGaetan89 MGaetan89 added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 8f3d650 May 13, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the 536-replace-deprecated-usages-of-mediaitemurn-with-srgmediaitembuilder branch May 13, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jboix jboix jboix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace deprecated usages of MediaItemUrn with SRGMediaItemBuilder
2 participants
@MGaetan89 @jboix