Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guide to setup the GitHub repository #534

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented May 7, 2024

Pull request

Description

This PR updates the readme to provide sample code for both cases to setup GitHub Packages repository: either in the root build.gradle or in the settings.gradle file.
It also make it clear that library desugaring should be enable even if the min SDK version is 24+.

Changes made

  • Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 added this to the 2.0.0 milestone May 7, 2024
@MGaetan89 MGaetan89 added the documentation Improvements or additions to documentation label May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Code Coverage

Overall Project 48.63% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 self-assigned this May 7, 2024
@MGaetan89 MGaetan89 requested a review from StaehliJ May 8, 2024 06:54
@StaehliJ StaehliJ added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit c71d60d May 8, 2024
10 checks passed
@StaehliJ StaehliJ deleted the update_readme branch May 8, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants