Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

517 helper for media route button display #525

Merged
merged 9 commits into from
May 22, 2024
Merged

517 helper for media route button display #525

merged 9 commits into from
May 22, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented May 2, 2024

Pull request

Description

The goal of this PR is to create a module for handling cast with Pillarbox and a specific demo. The library module provide a Composable to display a MediaRouterButton.

Changes made

  • Add module pillarbox-cast.
  • Add a cast demo.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue May 2, 2024 that may be closed by this pull request
Helper for media route button display #517
Closed
1 task
@StaehliJ StaehliJ modified the milestone: 2.0.0 May 2, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems May 2, 2024
View reviewed changes
gradle/libs.versions.toml Fixed Show fixed Hide fixed
gradle/libs.versions.toml Fixed Show fixed Hide fixed
gradle/libs.versions.toml Fixed Show fixed Hide fixed
gradle/libs.versions.toml Fixed Show fixed Hide fixed
gradle/libs.versions.toml Fixed Show fixed Hide fixed
gradle/libs.versions.toml Fixed Show fixed Hide fixed
gradle/libs.versions.toml Fixed Show fixed Hide fixed
gradle/libs.versions.toml Fixed Show fixed Hide fixed
gradle/libs.versions.toml Fixed Show fixed Hide fixed
gradle/libs.versions.toml Fixed Show fixed Hide fixed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Code Coverage

Overall Project 49.33% -0.54% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-cast 0% 🟢
Files
Module File Coverage
:pillarbox-cast CastExtensions.kt 0% 🟢
CastButton.kt 0% 🟢

MGaetan89
MGaetan89 approved these changes May 8, 2024
View reviewed changes
gradle/libs.versions.toml Show resolved Hide resolved
pillarbox-demo-cast/build.gradle.kts Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems May 8, 2024
View reviewed changes
gradle/libs.versions.toml Fixed Show fixed Hide fixed
gradle/libs.versions.toml Fixed Show fixed Hide fixed
gradle/libs.versions.toml Fixed Show fixed Hide fixed
gradle/libs.versions.toml Fixed Show fixed Hide fixed
gradle/libs.versions.toml Fixed Show fixed Hide fixed
gradle/libs.versions.toml Fixed Show fixed Hide fixed
@MGaetan89 MGaetan89 force-pushed the 517-helper-for-media-route-button-display branch from cedc7ab to a305099 Compare May 8, 2024 08:55
@StaehliJ StaehliJ added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit fdc494a May 22, 2024
10 checks passed
@StaehliJ StaehliJ deleted the 517-helper-for-media-route-button-display branch May 22, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helper for media route button display
2 participants
@StaehliJ @MGaetan89