Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate TimeRanges are it is a sealed interface and we don't really … #524

Merged
merged 2 commits into from
May 3, 2024
Merged

Separate TimeRanges are it is a sealed interface and we don't really … #524

merged 2 commits into from
May 3, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented May 2, 2024

…use abstraction.

Pull request

Description

The goal of this PR is to have the same structure for Asset and PillarboxData so it is easier to understand where to put what.

Changes made

  • Self-explanatory

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ added the enhancement New feature or request label May 2, 2024
@StaehliJ StaehliJ requested a review from MGaetan89 May 2, 2024 08:44
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

Code Coverage

Overall Project 48.67% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-core-business 84.28% 🟢
:pillarbox-player 49.35% 🟢
Files
Module File Coverage
:pillarbox-core-business SRGAssetLoader.kt 86.73% 🟢
:pillarbox-player Asset.kt 100% 🟢
PillarboxMediaSource.kt 91.92% 🟢

@MGaetan89 MGaetan89 added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 84ec709 May 3, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the refactoring-asset branch May 3, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees

@StaehliJ StaehliJ

Labels
enhancement New feature or request
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StaehliJ @MGaetan89