-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide simplified tracks management #495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
MGaetan89
force-pushed
the
492-provide-simplified-tracks-management
branch
from
April 12, 2024 15:14
f3041cc
to
0b5d72b
Compare
Code Coverage
Files
|
MGaetan89
force-pushed
the
492-provide-simplified-tracks-management
branch
from
April 16, 2024 11:43
0b5d72b
to
048d5bc
Compare
MGaetan89
force-pushed
the
492-provide-simplified-tracks-management
branch
2 times, most recently
from
April 18, 2024 19:05
e512d01
to
808c9c2
Compare
...c/main/java/ch/srgssr/pillarbox/demo/tv/ui/player/compose/settings/PlaybackSettingsDrawer.kt
Fixed
Show fixed
Hide fixed
...ox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/settings/SelectionSettingOptions.kt
Fixed
Show fixed
Hide fixed
Moved back to in progress:
|
MGaetan89
force-pushed
the
492-provide-simplified-tracks-management
branch
from
April 22, 2024 14:37
8229785
to
af047c2
Compare
MGaetan89
force-pushed
the
492-provide-simplified-tracks-management
branch
from
April 22, 2024 14:42
af047c2
to
0210eed
Compare
StaehliJ
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR provides new APIs to manage audio/text/video tracks. The new APIs are located in the
ch.srgssr.pillarbox.player.tracks
package in thepillarbox-player
module.Changes made
Quality
settings to allow the user to select the video qualityPlayer.videoQualities
extension returns a modified subset ofTracks.videoTracks
:Format.height
Behaviour changes
Checklist
main
branch.