Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the layout of "Lists" to match "Examples" #328

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Adjust the layout of "Lists" to match "Examples" #328

merged 3 commits into from
Nov 21, 2023

Conversation

MGaetan89
Copy link
Member

Pull request

Description

This PR updates the layout of the "Lists" section of the mobile demo app.

Changes made

  • Display a title on subsection of "Lists"
  • Align the design of each section to match what has been done in "Examples" and "Showcases"
  • Display an icon on media list to indicate if it is a video or an audio content

Screenshots

Description Light mode Dark mode
Main screen Screenshot_20231121_090927 Screenshot_20231121_091001
Sub-section Screenshot_20231121_090934 Screenshot_20231121_091005
Video list Screenshot_20231121_090939  Screenshot_20231121_091010
Audio list Screenshot_20231121_090950 Screenshot_20231121_091022

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

This was linked to issues Nov 21, 2023
Display an icon representing the media type in the "Lists" section #318
Closed
Align "Lists" design with "Examples" #324
Closed
@MGaetan89 MGaetan89 merged commit 76e2c4d into main Nov 21, 2023
4 checks passed
@MGaetan89 MGaetan89 deleted the 324-align-lists-design-with-examples branch November 21, 2023 14:55
@MGaetan89 MGaetan89 mentioned this pull request Nov 21, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defagos defagos defagos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align "Lists" design with "Examples" Display an icon representing the media type in the "Lists" section
2 participants
@MGaetan89 @defagos