Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corr bonczarowska2023 #1209

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

marcel-keller
Copy link
Contributor

Pull Request

This PR is for a

For the following list(s):

  • ancientsinglegenome-hostassociated (README)

Bonczarowska2023 is half-UDG data and not non-UDG, as stated in the previous version.
@jfy133
Copy link
Member

jfy133 commented Dec 10, 2024

@marcel-keller can you provide more context? The paper explicitly says non-UDG

All DNA samples were extracted and processed in a dedicated ancient DNA facility at the University of Kiel following the guidelines on contamination control in ancient DNA [5759], according to a previously published protocol for the non-UGD treated samples [60]. Shotgun sequencing was performed on the Illumina HiSeq 6000 (2 × 100) platform of the Institute of Clinical Molecular Biology in Kiel.

https://royalsocietypublishing.org/doi/10.1098/rspb.2023.0622#d1e1878

@marcel-keller
Copy link
Contributor Author

I saw it when I processed the data, and I just wrote Joanna Bonczarowska, she confirmed that it is a mistake in the paper.

@marcel-keller
Copy link
Contributor Author

Screenshot 2024-12-10 at 15 47 42

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me if tests pass

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: James A. Fellows Yates <[email protected]>
@jfy133
Copy link
Member

jfy133 commented Dec 11, 2024

Check failure here is due to PR coming from a fork stopping the automated comment posting.

Checks indeed pass, I manually downloaded the results which can be viewed here

results.zip

I'll merge now @marcel-keller ! Thank you!

@jfy133 jfy133 merged commit fb1aea1 into SPAAM-community:master Dec 11, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants