Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valeur seersholm 2024 #1192

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Valeur seersholm 2024 #1192

wants to merge 6 commits into from

Conversation

YuejiaoHuang
Copy link
Contributor

Pull Request

This PR is for a

For the following list(s):

  • ancientmetagenome-environmental (README)
  • ancientmetagenome-hostassociated (README)
  • ancientsinglegenome-hostassociated (README)

This is to close

PR Workflow

  1. Open this PR with sample metadata on the samples metadata sheet (:tada: you're already here!)
  2. Wait for checks for sample metdata to pass
  3. (If checks fail) make corrections, and push changes to this branch (no need to open a new PR!)
  4. (Once passed) comment on this PR @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! (may take a minute or so to get the comment with the file)
  5. Fill in the template, and verify autofilled data correct!
  6. Once filled in, append(!) the new rows from the TEMPLATE file to the end of the corresponding library metadata file, and update this PR
  7. Wait for checks for library metadata to pass
  8. Request review!

Pre-review checklist (new publications)

  • Publication is published
    • Preprints currently not accepted?
  • Checked the publication is not already in the database?
  • Checked samples in this publication are not previously published data?
    • Newly re-sequenced metagenomes are OK!
  • Samples are shotgun metagenomes and not amplicon data
    • Note: hostassociated-singlegenome may also contain whole-genome enriched data
  • Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
  • Once sample table validation completed Library metadata has been added
    • Use @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! May take a minute or so to get the comment with the file
    • Fill in template, and verify autofill data correct!
    • Once filled in, append(!) the new rows to the end of the corresponding library metadata file
  • Changelog is updated to include the publication under 'Added'?

@YuejiaoHuang YuejiaoHuang linked an issue Oct 2, 2024 that may be closed by this pull request
@SPAAM-community SPAAM-community deleted a comment from github-actions bot Oct 2, 2024
@SPAAM-community SPAAM-community deleted a comment from github-actions bot Oct 2, 2024
@YuejiaoHuang
Copy link
Contributor Author

@spaam-bot please autofill ancientsinglegenome-hostassociated Seersholm2024

@jfy133 jfy133 force-pushed the master branch 3 times, most recently from 49ac494 to 62f90dc Compare October 5, 2024 04:40
@jfy133
Copy link
Member

jfy133 commented Oct 7, 2024

@spaam-bot please autofill ancientsinglegenome-hostassociated Seersholm2024

Copy link

github-actions bot commented Oct 7, 2024

nf-core/taxprofiler

Autofill success! 🎉

Autofill log:

�[32mAMDirT [INFO]: ancientsinglegenome-hostassociated_libraries.tsv is valid�[0m
�[32mAMDirT [INFO]: ENA API is up�[0m
�[32mAMDirT [INFO]: Found 353 libraries�[0m
�[32mAMDirT [INFO]: Writing libraries metadata to TEMPLATE_Seersholm2024_ancientsinglegenome-hostassociated_libraries.tsv�[0m

Download the attempted autofilled library file by pressing this link.

You can now fill in the remainder of the columns, and append to the end of the corresponding library file.
Please remember this service attempts to pull relevant metadata from the ENA, but metadata is not always correct!

Warning

Always check accuracy of pre-filled columns before adding to the library table!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Valeur Seersholm 2024
2 participants