Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gancz2023 #1128

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Gancz2023 #1128

wants to merge 4 commits into from

Conversation

LooseGoose99
Copy link
Contributor

@LooseGoose99 LooseGoose99 commented Dec 12, 2023

Pull Request

This PR is for a

For the following list(s):

  • ancientmetagenome-environmental (README)
  • ancientmetagenome-hostassociated (README)
  • ancientsinglegenome-hostassociated (README)

New Publication

Publication Information

This pull request is to add samples from the following publication(s): 10.1038/s41564-023-01527-3

This is to close

Checklist

  • Publication is published (preprints currently not accepted)?
  • Checked the publication is not already in the database?
  • Checked samples in this publication are not previously published data (newly re-sequenced metagenomes are OK!)?
  • Samples are shotgun metagenomes (hostassociated-singlegenome may also contain whole-genome enriched data)?
  • Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
  • Changelog is updated to include the publication under 'Added'?
  • Pull request has passed validation checks (see automated comment from github-bot)?
  • Review requested from @SPAAM-community/ancientmetagenomedir?
  • (If applicable) Made a separate PR to add new categories to controlled lists (stored under /assets/enums, e.g. material or archive)? If so the corresponding PR is here:

Copy link

AMDirT, version 1.4.6

Samples

Ancient Metagenome Host Associated

Invalid dataset ancientmetagenome-hostassociated_samples.tsv

Error Source Column Row Message
Schema Validation Error Scotland geo_loc_name 1414 'Scotland' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/geo_loc_name.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/geo_loc_name.json[/link]
Schema Validation Error Scotland geo_loc_name 1415 'Scotland' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/geo_loc_name.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/geo_loc_name.json[/link]

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

Copy link

AMDirT, version 1.4.6

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

@alexhbnr
Copy link
Collaborator

Hi @LooseGoose99,

Thanks for adding your samples. There are a few minor things that need to changed before I can approve the merging:

  • the entries in the sample age column should be rounded to the nearest 100 (see https://github.com/SPAAM-community/AncientMetagenomeDir/tree/master/ancientmetagenome-hostassociated/samples#sample_age)
  • I couldn't find any information on the longitude/latitude of the individual cementeries so I guess this is internal knowledge. However, we have the rule that longitude/latitude Can be searched in wider literature, rough location is acceptable but use fewer decimals. In case, your coordinates point to rough estimates, I would suggest to reduce the precision of longitude/latitude to two decimals.

Is there already an update on uploading the unmerged sequencing data to ENA?

@jfy133 jfy133 force-pushed the master branch 9 times, most recently from 223e767 to c16a3da Compare March 21, 2024 16:32
@jfy133 jfy133 marked this pull request as draft April 5, 2024 11:16
@jfy133 jfy133 force-pushed the master branch 3 times, most recently from 49ac494 to 62f90dc Compare October 5, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants