Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Madison_enums_sample_host.json #1121

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Madison_enums_sample_host.json #1121

merged 2 commits into from
Nov 30, 2023

Conversation

DianaSpurite
Copy link
Contributor

adding Rana pipiens

Pull Request

This PR is for a

For the following list(s):

  • ancientmetagenome-environmental (README)
  • ancientmetagenome-hostassociated (README)
  • ancientsinglegenome-hostassociated (README)

New Publication

Publication Information

This pull request is to add samples from the following publication(s):

This is to close

Checklist

  • Publication is published (preprints currently not accepted)?
  • Checked the publication is not already in the database?
  • Checked samples in this publication are not previously published data (newly re-sequenced metagenomes are OK!)?
  • Samples are shotgun metagenomes (hostassociated-singlegenome may also contain whole-genome enriched data)?
  • Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
  • Changelog is updated to include the publication under 'Added'?
  • Pull request has passed validation checks (see automated comment from github-bot)?
  • Review requested from @SPAAM-community/ancientmetagenomedir?
  • (If applicable) Made a separate PR to add new categories to controlled lists (stored under /assets/enums, e.g. material or archive)? If so the corresponding PR is here:

adding Rana pipiens
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

AMDirT, version 1.4.6

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

@jfy133
Copy link
Member

jfy133 commented Oct 3, 2023

Could you check this by searching NCBI taxonomy? I can't find it on a brief search...

@DianaSpurite
Copy link
Contributor Author

ould you check this by searching NCBI taxonomy? I can't fi

I don't exactly understand what you mean.. I went on the NCBI and found this: https://www.ncbi.nlm.nih.gov/Taxonomy/Browser/wwwtax.cgi?id=8404

@jfy133
Copy link
Member

jfy133 commented Oct 4, 2023

Ahh, ok Rana pipen is the old name (basionym) - you should use the new one as on the page :)

@DianaSpurite
Copy link
Contributor Author

Ahh, ok Rana pipen is the old name (basionym) - you should use the new one as on the page :)

Which is the new one - Pantherana pipiens?

@DianaSpurite
Copy link
Contributor Author

Ahh, ok Rana pipen is the old name (basionym) - you should use the new one as on the page :)

Lithobates pipiens (Schreber, 1782), basionym: Rana pipiens Schreber, 1782

@jfy133
Copy link
Member

jfy133 commented Oct 6, 2023

Lithobates pipiens 👍

Updating to newer version of genera namehttps://github.com//pull/1121
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

AMDirT, version 1.4.6

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

@DianaSpurite DianaSpurite requested a review from jfy133 October 9, 2023 09:01
@DianaSpurite DianaSpurite mentioned this pull request Oct 9, 2023
14 tasks
@DianaSpurite DianaSpurite changed the title Update sample_host.json Madison_enums_sample_host.json Oct 9, 2023
@alexhbnr alexhbnr merged commit 3bcf504 into master Nov 30, 2023
1 check passed
@alexhbnr alexhbnr deleted the MadisonEnums branch November 30, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants