Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hodgkins2023 #1117

Merged
merged 21 commits into from
Dec 4, 2023
Merged

Hodgkins2023 #1117

merged 21 commits into from
Dec 4, 2023

Conversation

DianaSpurite
Copy link
Contributor

@DianaSpurite DianaSpurite commented Sep 28, 2023

Adding Hodgkind2023 samples

Pull Request

This PR is for a

For the following list(s):

  • ancientmetagenome-environmental (README)
  • ancientmetagenome-hostassociated (README)
  • ancientsinglegenome-hostassociated (README)

New Publication

Publication Information

This pull request is to add samples from the following publication(s):

This is to close #1109

Checklist

  • Publication is published (preprints currently not accepted)?
  • Checked the publication is not already in the database?
  • Checked samples in this publication are not previously published data (newly re-sequenced metagenomes are OK!)?
  • Samples are shotgun metagenomes (hostassociated-singlegenome may also contain whole-genome enriched data)?
  • Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
  • Changelog is updated to include the publication under 'Added'?
  • Pull request has passed validation checks (see automated comment from github-bot)?
  • Review requested from @SPAAM-community/ancientmetagenomedir?
  • (If applicable) Made a separate PR to add new categories to controlled lists (stored under /assets/enums, e.g. material or archive)? If so the corresponding PR is here: Hodkins2023 singlegenome_species.json #1118

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as resolved.

added Caruana 2023
@DianaSpurite DianaSpurite changed the title Update ancientsinglegenome-hostassociated_samples.tsv Caruana2023 Sep 28, 2023
@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@DianaSpurite
Copy link
Contributor Author

I'll leave a bunch of comments with information later today to help with reviewing process

@DianaSpurite DianaSpurite requested a review from jfy133 September 28, 2023 17:41
@DianaSpurite DianaSpurite changed the title Caruana2023 Hodgkins2023 Sep 28, 2023
Adding the correct name of the author
@github-actions

This comment was marked as resolved.

- added the correct author's name 
- corrected the last polymerase
- added under-strokes in the library names for Deir-Rifeh-KNIII-Tooth and Deir-Rifeh-KNII-Tooth sample libraries
@github-actions

This comment was marked as outdated.

replaced the wrong author with the correct one - Hodgkins2023
@github-actions

This comment was marked as outdated.

@DianaSpurite
Copy link
Contributor Author

When the species PR is approved the commit should become validated

@DianaSpurite
Copy link
Contributor Author

For the reviewer(s):

SAMPLES:

  • All sample information is taken from Hodgkins 2023 publication supplementary table and main text, including sample age, sample material and coordinates (shortened in some cases to 3 decimals). Excluding PRJ numbers, SRS/ERS numbers and subsequently which archive.
  • Tenerife-004-Tooth sample age not provided, therefore I set it the same as the age of the other sample from the same site
  • For Vác-Mummy-Tissue sample, the material was stated to be "left chest extract", so I set it as simply "tissue"
  • Pericues-BC28-Bone sample age left as 550 as I wasn't sure if I should round up or down

@DianaSpurite
Copy link
Contributor Author

For the reviewer(s):

LIBRARIES:

  • Links to all the original studies for each sample are available in the Hodgkins supplementary table "Supp Data 2"

I looked for the information here:

correcting author
@github-actions
Copy link

AMDirT, version 1.4.6

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

@DianaSpurite
Copy link
Contributor Author

Sample age calculated considering 1950 as the present time

@iseultj
Copy link
Contributor

iseultj commented Sep 29, 2023

Hi Diana, Thanks for doing this! I noticed a couple of things:

For Sanganji-A1-Tooth and Sanganji-A2-Tooth, it says the polymerase is unknown- I checked the Qiagen multiplex PCR handbook, and it looks like they use a HotStarTaq polymerase, but I'm not sure if that's what they actually used.

For Deir-Rifeh-KNIII-Tooth and Deir-Rifeh-KNII-Tooth - you put half-udg but I can't find any reference to it in the original paper?

For Tepos, I think the polymerases used were Accuprime (Taq) polymerase and then further amplification with Herculase II Fusion DNA Polymerase (agilent)

For the Chincha samples, it might be best to leave the polymerase as unknown? I wasn't able to figure it out either....

For Chiribaya_Alta-Bone and El_Yaral-Bone-in the supplement, it does state it's UDG treated, so I think ok to leave as is.

Finally, for Pueblo_Bonito-Tooth, in the main text it also says it was paired, so I don't know what's going on with the library layout.

Thanks for going through all of these and leaving the details for me, it made reviewing so much easier!

@github-actions
Copy link

AMDirT, version 1.4.6

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

@github-actions
Copy link

AMDirT, version 1.4.6

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

AMDirT, version 1.4.6

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

Invalid dataset ancientsinglegenome-hostassociated_libraries.tsv

Error Source Column Row Message
Schema Validation Error HotStarTaq DNA Polymerase DNA library_polymerase 2870 'HotStarTaq DNA Polymerase DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

AMDirT, version 1.4.6

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

Invalid dataset ancientsinglegenome-hostassociated_libraries.tsv

Error Source Column Row Message
Schema Validation Error HotStarTaq DNA library_polymerase 2868 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2869 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2870 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2871 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2872 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2873 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2874 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2875 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2876 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2877 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2878 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2879 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2880 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2881 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

AMDirT, version 1.4.6

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

Invalid dataset ancientsinglegenome-hostassociated_libraries.tsv

Error Source Column Row Message
Schema Validation Error HotStarTaq DNA library_polymerase 2868 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2869 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2870 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2871 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2872 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2873 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2874 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2875 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2876 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2877 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2878 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2879 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2880 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]
Schema Validation Error HotStarTaq DNA library_polymerase 2881 'HotStarTaq DNA' is not an accepted value.
Please check [link=https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json]https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/library_polymerase.json[/link]

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

AMDirT, version 1.4.6

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

@DianaSpurite
Copy link
Contributor Author

Hi Diana, Thanks for doing this! I noticed a couple of things:

For Sanganji-A1-Tooth and Sanganji-A2-Tooth, it says the polymerase is unknown- I checked the Qiagen multiplex PCR handbook, and it looks like they use a HotStarTaq polymerase, but I'm not sure if that's what they actually used.

For Deir-Rifeh-KNIII-Tooth and Deir-Rifeh-KNII-Tooth - you put half-udg but I can't find any reference to it in the original paper?

For Tepos, I think the polymerases used were Accuprime (Taq) polymerase and then further amplification with Herculase II Fusion DNA Polymerase (agilent)

For the Chincha samples, it might be best to leave the polymerase as unknown? I wasn't able to figure it out either....

For Chiribaya_Alta-Bone and El_Yaral-Bone-in the supplement, it does state it's UDG treated, so I think ok to leave as is.

Finally, for Pueblo_Bonito-Tooth, in the main text it also says it was paired, so I don't know what's going on with the library layout.

Thanks for going through all of these and leaving the details for me, it made reviewing so much easier!

I have addressed all these points, so I think it's good to go now. Thankfully, this issue was much easier than anticipated due to coordinates being available and James's suggestion to indicate exactly where in original publications the info could be found! Thank you both for your help along the process and with reviewing!

@DianaSpurite
Copy link
Contributor Author

I am also requesting a review from you @alexhbnr as you are at it at the moment. This is already revised and there are comments and changes made. If you have a moment, could you please have a look and merge this also?

@DianaSpurite DianaSpurite requested a review from alexhbnr December 1, 2023 11:37
@DianaSpurite
Copy link
Contributor Author

the sample(s?) excluded from the table here are previously sequenced

@alexhbnr
Copy link
Collaborator

alexhbnr commented Dec 1, 2023

I will review it properly at the beginning of next week @DianaSpurite.
I started reviewing it yesterday and realised that all DOIs are pointing to the paper by Caruana et al. instead of Hodgkins et al. I have contacted @jfy133 about how we should handle the publication DOIs of the samples as the samples have been previously published (see Supp. Data Table 2). @jfy133 pointed me to check the previous publications that had the same issue, e.g. Bieker2020 and the Oetzi publication. I will do this next week.

@DianaSpurite
Copy link
Contributor Author

DianaSpurite commented Dec 1, 2023

all DOIs are pointing to the paper by Caruana et al. instead of Hodgkins et al.

yes, that sound like my mistake, I mixed up at the beginning of working with this publication.

Thank you for looking into this, let me know if I can help.

Change publication DOI to Hodgkins2023 manuscript and sample age DOIs to the original publication reported in Hodgkins2023 Suppl. Data S2
@alexhbnr
Copy link
Collaborator

alexhbnr commented Dec 4, 2023

Hi @DianaSpurite and @iseultj,

I went through your review and have a few questions/comments that I am not completely sure about:

  1. For the samples Sanganji-A1-Tooth and Sanganji-A2-Tooth, you have listed that your polymerase that was used for the library amplification was HotStarTaq DNA (see also comment by @iseultj). What I found in the Suppl. Materials is a link to this study (https://doi.org/10.1126/science.1211177) and they stated that they use two rounds of PCR amplification, one time with AmpliTaq Gold and once with Phusion. So I am puzzled how you ended up with HotStarTaq DNA instead?
  2. For the sample Tepos_35-Tooth, there is already an entry from the original publication, so I would suggest to copy the info from there.
  3. All references to the protocol "Meyer and Kircher, 2010" should have the "Phusion Hot Start High-Fidelity DNA" polymerase, as this is the one listed in their protocol.
  4. For the Dacaozi-Tooth sample, the two protocols that are listed were only used for the DNA extraction steps but not for the library preparation steps. From their description of the library protocol steps, it is not apparent, which protocol they used. I would therefore propose to set it to "Unknown".

If you could please check the first question, I would then approve the review and we can merge with the master branch.

Copy link

github-actions bot commented Dec 4, 2023

AMDirT, version 1.4.6

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

@DianaSpurite
Copy link
Contributor Author

  1. For the samples Sanganji-A1-Tooth and Sanganji-A2-Tooth, you have listed that your polymerase that was used for the library amplification was HotStarTaq DNA (see also comment by @iseultj). What I found in the Suppl. Materials is a link to this study (https://doi.org/10.1126/science.1211177) and they stated that they use two rounds of PCR amplification, one time with AmpliTaq Gold and once with Phusion. So I am puzzled how you ended up with HotStarTaq DNA instead?

I had set it to 'Unknown' initially, exactly because they state two, and my competence level is rather low when it comes to the sequencing methods, so I corrected it according to the review.

  1. For the sample Tepos_35-Tooth, there is already an entry from the original publication, so I would suggest to copy the info from there.

I will check and do so.

  1. All references to the protocol "Meyer and Kircher, 2010" should have the "Phusion Hot Start High-Fidelity DNA" polymerase, as this is the one listed in their protocol.

Can you please confirm - does this mean for Deir-Rifeh; Cueva_de_los_Lagos and Punta_Candelero samples?

  1. For the Dacaozi-Tooth sample, the two protocols that are listed were only used for the DNA extraction steps but not for the library preparation steps. From their description of the library protocol steps, it is not apparent, which protocol they used. I would therefore propose to set it to "Unknown".

Will fix this too

If you could please check the first question, I would then approve the review and we can merge with the master branch.

@alexhbnr
Copy link
Collaborator

alexhbnr commented Dec 4, 2023

@DianaSpurite for points 2 to 4, I should have already done this, so nothing to worry there at the moment.
Thanks for clarifying question 1. I will wait for @iseultj's feedback and then go ahead.

Thanks @DianaSpurite for putting all the work in the first place. That was a beast of a publication to add to AMDir.

@iseultj
Copy link
Contributor

iseultj commented Dec 4, 2023

Hi, the HotStart Taq was my mistake - I was looking at their SM where they include the following as modifications to the Rasmussen protocol: A first round PCR was set up with Multiplex PCR kit (Qiagen) as follows: 5 µl DNA library, 25 µl Mix, 20-100 nM each Multiplexing PCR primer, and H2O up to 50 µl... I looked at the multiplex PCR (qiagen) handbook to find it, but to be honest I wasn't clear whether they used the HotStart Taq or the enzymes used in the Rasmussen paper - maybe Unknown is the best way forward? Sorry for neglecting this PR, and thanks so much to both of you for both doing all the work and finishing it off!

Copy link

github-actions bot commented Dec 4, 2023

AMDirT, version 1.4.6

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

Copy link

github-actions bot commented Dec 4, 2023

AMDirT, version 1.4.6

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

@alexhbnr alexhbnr merged commit 2f80fb7 into master Dec 4, 2023
1 check passed
@alexhbnr alexhbnr deleted the Caruana2013 branch December 4, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hodgkins 2023
4 participants