-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hodgkins2023 #1117
Hodgkins2023 #1117
Conversation
Adding Caruana2023 samples
Adding Caruana2023 libraries
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
added Caruana 2023
This comment was marked as resolved.
This comment was marked as resolved.
Correcting library_Polymerase
This comment was marked as resolved.
This comment was marked as resolved.
I'll leave a bunch of comments with information later today to help with reviewing process |
Adding the correct name of the author
This comment was marked as resolved.
This comment was marked as resolved.
- added the correct author's name - corrected the last polymerase - added under-strokes in the library names for Deir-Rifeh-KNIII-Tooth and Deir-Rifeh-KNII-Tooth sample libraries
This comment was marked as outdated.
This comment was marked as outdated.
replaced the wrong author with the correct one - Hodgkins2023
This comment was marked as outdated.
This comment was marked as outdated.
When the species PR is approved the commit should become validated |
For the reviewer(s): SAMPLES:
|
For the reviewer(s): LIBRARIES:
I looked for the information here:
|
correcting author
AMDirT, version 1.4.6 SamplesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
LibrariesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
|
Sample age calculated considering 1950 as the present time |
Hi Diana, Thanks for doing this! I noticed a couple of things: For Sanganji-A1-Tooth and Sanganji-A2-Tooth, it says the polymerase is unknown- I checked the Qiagen multiplex PCR handbook, and it looks like they use a HotStarTaq polymerase, but I'm not sure if that's what they actually used. For Deir-Rifeh-KNIII-Tooth and Deir-Rifeh-KNII-Tooth - you put half-udg but I can't find any reference to it in the original paper? For Tepos, I think the polymerases used were Accuprime (Taq) polymerase and then further amplification with Herculase II Fusion DNA Polymerase (agilent) For the Chincha samples, it might be best to leave the polymerase as unknown? I wasn't able to figure it out either.... For Chiribaya_Alta-Bone and El_Yaral-Bone-in the supplement, it does state it's UDG treated, so I think ok to leave as is. Finally, for Pueblo_Bonito-Tooth, in the main text it also says it was paired, so I don't know what's going on with the library layout. Thanks for going through all of these and leaving the details for me, it made reviewing so much easier! |
AMDirT, version 1.4.6 SamplesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
LibrariesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
|
AMDirT, version 1.4.6 SamplesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
LibrariesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
|
All suggestions addressed
AMDirT, version 1.4.6 SamplesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
LibrariesAncient Metagenome Host Associated
Ancient Single Genome Host AssociatedInvalid dataset
Ancient Metagenome Environmental
|
AMDirT, version 1.4.6 SamplesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
LibrariesAncient Metagenome Host Associated
Ancient Single Genome Host AssociatedInvalid dataset
Ancient Metagenome Environmental
|
1 similar comment
AMDirT, version 1.4.6 SamplesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
LibrariesAncient Metagenome Host Associated
Ancient Single Genome Host AssociatedInvalid dataset
Ancient Metagenome Environmental
|
AMDirT, version 1.4.6 SamplesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
LibrariesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
|
I have addressed all these points, so I think it's good to go now. Thankfully, this issue was much easier than anticipated due to coordinates being available and James's suggestion to indicate exactly where in original publications the info could be found! Thank you both for your help along the process and with reviewing! |
I am also requesting a review from you @alexhbnr as you are at it at the moment. This is already revised and there are comments and changes made. If you have a moment, could you please have a look and merge this also? |
the sample(s?) excluded from the table here are previously sequenced |
I will review it properly at the beginning of next week @DianaSpurite. |
yes, that sound like my mistake, I mixed up at the beginning of working with this publication. Thank you for looking into this, let me know if I can help. |
…Dir into Caruana2013
Change publication DOI to Hodgkins2023 manuscript and sample age DOIs to the original publication reported in Hodgkins2023 Suppl. Data S2
Hi @DianaSpurite and @iseultj, I went through your review and have a few questions/comments that I am not completely sure about:
If you could please check the first question, I would then approve the review and we can merge with the master branch. |
AMDirT, version 1.4.6 SamplesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
LibrariesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
|
I had set it to 'Unknown' initially, exactly because they state two, and my competence level is rather low when it comes to the sequencing methods, so I corrected it according to the review.
I will check and do so.
Can you please confirm - does this mean for Deir-Rifeh; Cueva_de_los_Lagos and Punta_Candelero samples?
Will fix this too
|
@DianaSpurite for points 2 to 4, I should have already done this, so nothing to worry there at the moment. Thanks @DianaSpurite for putting all the work in the first place. That was a beast of a publication to add to AMDir. |
Hi, the HotStart Taq was my mistake - I was looking at their SM where they include the following as modifications to the Rasmussen protocol: A first round PCR was set up with Multiplex PCR kit (Qiagen) as follows: 5 µl DNA library, 25 µl Mix, 20-100 nM each Multiplexing PCR primer, and H2O up to 50 µl... I looked at the multiplex PCR (qiagen) handbook to find it, but to be honest I wasn't clear whether they used the HotStart Taq or the enzymes used in the Rasmussen paper - maybe Unknown is the best way forward? Sorry for neglecting this PR, and thanks so much to both of you for both doing all the work and finishing it off! |
AMDirT, version 1.4.6 SamplesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
LibrariesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
|
AMDirT, version 1.4.6 SamplesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
LibrariesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
|
Adding Hodgkind2023 samples
Pull Request
This PR is for a
For the following list(s):
New Publication
Publication Information
This pull request is to add samples from the following publication(s):
This is to close #1109
Checklist
github-bot
)?@SPAAM-community/ancientmetagenomedir
?/assets/enums
, e.g. material or archive)? If so the corresponding PR is here: Hodkins2023 singlegenome_species.json #1118