Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murchie2023 #1164

Merged
merged 7 commits into from
Apr 8, 2024
Merged

Murchie2023 #1164

merged 7 commits into from
Apr 8, 2024

Conversation

ktozdogan
Copy link
Contributor

@ktozdogan ktozdogan commented Apr 5, 2024

Pull Request

This PR is for a

For the following list(s):

  • ancientmetagenome-environmental (README)
  • ancientmetagenome-hostassociated (README)
  • ancientsinglegenome-hostassociated (README)

This is to close #1129

PR Workflow

  1. Open this PR with sample metadata on the samples metadata sheet (:tada: you're already here!)
  2. Wait for checks for sample metdata to pass
  3. (If checks fail) make corrections, and push changes to this branch (no need to open a new PR!)
  4. (Once passed) comment on this PR @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! (may take a minute or so to get the comment with the file)
  5. Fill in the template, and verify autofilled data correct!
  6. Once filled in, append(!) the new rows from the TEMPLATE file to the end of the corresponding library metadata file, and update this PR
  7. Wait for checks for library metadata to pass
  8. Request review!

Pre-review checklist (new publications)

  • Publication is published
    • Preprints currently not accepted?
  • Checked the publication is not already in the database?
  • Checked samples in this publication are not previously published data?
    • Newly re-sequenced metagenomes are OK!
  • Samples are shotgun metagenomes and not amplicon data
    • Note: hostassociated-singlegenome may also contain whole-genome enriched data
  • Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
  • Once sample table validation completed Library metadata has been added
    • Use @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! May take a minute or so to get the comment with the file
    • Fill in template, and verify autofill data correct!
    • Once filled in, append(!) the new rows to the end of the corresponding library metadata file
  • Changelog is updated to include the publication under 'Added'?

Copy link

github-actions bot commented Apr 8, 2024

AMDirT, version 1.5.0

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

@alexhbnr
Copy link
Collaborator

alexhbnr commented Apr 8, 2024

Thanks @ktozdogan for the PR. I have reviewed it and added one sample, SET-279-SG, to both the sample and library table. In their Supplementary table Table S1, Murchie2023 defined it as a shotgun sample, which is indicated both in the sample name and in a separated column. However, on ENA, its library strategy was set to "targeted capture".

I think the latter information on ENA is wrong. After discussing with @jfy133, we will add the sample and library for the moment and I will email the authors about it. In case this is indeed a capture-enriched sample, we will remove it in a later release.

@alexhbnr alexhbnr merged commit 5fed4f1 into master Apr 8, 2024
1 check passed
@alexhbnr alexhbnr deleted the Murchie2023 branch April 8, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Murchie 2023
2 participants