Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/hyoin/1 #7

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Dev/hyoin/1 #7

wants to merge 10 commits into from

Conversation

Hyoin-Kim
Copy link
Member

@Hyoin-Kim Hyoin-Kim commented May 21, 2021

✅ PR check list

- commit message가 적절한지 확인해주세요. 
- 마지막으로 Coding Convention을 준수했는지 확인해주세요.
- 적절한 branch로 요청했는지 확인해주세요.
- Assignees, Label을 붙여주세요.
- 가능한 이슈를 Link 해주세요.
- PR이 승인된 경우 해당 브랜치는 삭제 부탁드립니다.

🌈 PR 요약

  1. GlobalStyles.js padding-left 값 주석처리 (이 값으로 작업 결과물 배치가 조금 이상해지더라구요..)
  2. second.js 두번째 페이지 가운데 컴포넌트 구현
  3. assets/component에 에셋 추가
  4. 폰트 미적용

📌 변경 사항

변경사항 및 주의 사항 (모듈 설치 등)을 적어주세요.

📸 ScreenShot

Linked Issue

close #Issue number

Copy link
Member

@rdd9223 rdd9223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node_modules 파일을 .gitignore에 추가해주시면 좋을 것 같아요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants