Chore: axios 초기설정 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
📚 Tasks
👀 To Reviewer
우선적으로 종속성을 apps/client 에 추가하고, axios 인스턴스를 설정합니다 baseUrl 은 아직 나오지 않아서 임의로 설정해두고 주석 표시 해두었습니다.
response 인터셉터 설정은 모두 주석처리 해놓았고,
status와errorMessage는치현님이 보내준 서버 응답 데이터 양식을 참고해서 우선적으로 설정해두었습니다.status와errorMessage를 처리하는 로직같은 경우 interceptors 로직 내부에서 처리하기도 하지만, 상태값과 에러메시지를 핸들링하는 함수를 하나 만들어서 처리하는 것이 어떠한가..?하는 생각이 있습니다같은 목적인데 코드가 분산되는 것 같다는 걱정도 있는데, 이 부분에 대해서 의견주시면 감사하겠습니다.
📸 Screenshot
서버 응답 형식
