[Feat/#52] "모임 상세 뷰" UI를 구현합니다. #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinseoSONG
approved these changes
Jan 18, 2025
Comment on lines
78
to
95
| Box( | ||
| modifier = Modifier.roundedBackgroundWithBorder( | ||
| cornerRadius = 4.dp, | ||
| backgroundColor = GongBaekTheme.colors.gray01 | ||
| ) | ||
| ) { | ||
| Text( | ||
| text = groupIntroduction, | ||
| modifier = Modifier.padding(16.dp), | ||
| color = GongBaekTheme.colors.gray08, | ||
| style = GongBaekTheme.typography.body2.r14 | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| item { | ||
| Spacer(modifier = Modifier.height(30.dp)) | ||
| } |
There was a problem hiding this comment.
[3]: 이 부분을 Box에서부터 아래 Spacer까지 묶어서 item으로 빼는게 좋지않을까요 ?? 코드 가독성 측면에서 더 좋을 것 같아요 !
Comment on lines
209
to
221
| Text( | ||
| text = groupHost.mbti, | ||
| color = GongBaekTheme.colors.gray08, | ||
| style = GongBaekTheme.typography.caption2.m12 | ||
| ) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| item { | ||
| Spacer(modifier = Modifier.height(10.dp)) |
wjdrjs00
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
issue.52group-detail.mp4
Uncompleted Tasks 😅
To Reviewers 📢
기본적인 UI 구현이 끝났습니다. 이제 도메인 레이어 보완과 함께 로직 구현에 들어갈게요~~~~