Merge pull request #17 from SOFware/fix/end-of-last-completed

Fix/end of last completed

CHANGELOG.md

@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.1.5] - Unreleased
+## [0.1.5] - 2024-09-02
+
+### Fixed
+
+- `Cycle#last_completed` works for dormant cycles too
 
 ## [0.1.4] - 2024-09-02
 

lib/sof/cycles/end_of.rb

@@ -25,7 +25,7 @@ def to_s
       end
 
       # Always returns the from_date
-      def last_completed(_) = from_date.to_date
+      def last_completed(_ = nil) = from_date&.to_date
 
       # Returns the expiration date for the cycle
       #

spec/sof/cycles/dormant_spec.rb

@@ -29,6 +29,20 @@ module SOF
 
     it_behaves_like "#kind returns", :dormant
 
+    describe "#last_completed" do
+      context "with a dormant Within cycle" do
+        it "returns nil" do
+          expect(within_cycle.last_completed(completed_dates)).to eq recent_date
+        end
+      end
+
+      context "with a dormant EndOf cycle" do
+        it "returns nil" do
+          expect(end_of_cycle.last_completed).to be_nil
+        end
+      end
+    end
+
     describe "#recurring?" do
       it "does not repeat" do
         expect(within_cycle).not_to be_recurring

spec/sof/cycles/end_of_spec.rb

@@ -39,7 +39,20 @@ module SOF
     it_behaves_like "#as_json returns the notation"
     it_behaves_like "it computes #final_date(given)",
       given: nil, returns: ("2020-01-01".to_date + 17.months).end_of_month
-    it_behaves_like "last_completed is", :from_date
+
+    describe "#last_completed" do
+      context "with an activated cycle" do
+        it_behaves_like "last_completed is", :from_date
+      end
+
+      context "with a dormant cycle" do
+        let(:notation) { "V2E18M" }
+
+        it "returns nil" do
+          expect(cycle.last_completed).to be_nil
+        end
+      end
+    end
 
     describe "#covered_dates" do
       let(:completed_dates) do