Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move special "_optimize_hyperparam" functions outside krg_based.py #648

Closed
wants to merge 25 commits into from
Closed

Move special "_optimize_hyperparam" functions outside krg_based.py #648

wants to merge 25 commits into from

Conversation

Paul-Saves
Copy link
Contributor

@Paul-Saves Paul-Saves commented Sep 17, 2024 •
edited
Loading

Move special "_optimize_hyperparam" functions outside krg_based.py

  • Move SGP, MGP & KPLSK peculiar "_optimize_hyperparam"
  • Move "compute_n_param" from krg_based to utils
  • Maybe transform krg_based into a metaclass?

@Paul-Saves Paul-Saves marked this pull request as draft September 17, 2024 08:39
@Paul-Saves Paul-Saves closed this Dec 6, 2024
@Paul-Saves Paul-Saves reopened this Dec 6, 2024
@Paul-Saves Paul-Saves marked this pull request as ready for review December 6, 2024 16:01
@Paul-Saves Paul-Saves closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Paul-Saves