Refactor message Ack/Nack using events #2068
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This uses event callbacks to allow decoupling of Consumers (including subclasses) and the RabbitMQ
IModel
interface. We will now be able to simplify the test suite and reduce the total execution time. The next step will be to remove all usage ofIModel
outside of the RabbitMQBroker class.Types of changes
[skip ci]
Checklist
By opening this PR, I confirm that I have:
@SMI/Reviewers
teamIssues