Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor message Ack/Nack using events #2068

Merged
merged 5 commits into from
Dec 30, 2024
Merged

Refactor message Ack/Nack using events #2068

merged 5 commits into from
Dec 30, 2024

Conversation

rkm
Copy link
Member

@rkm rkm commented Dec 30, 2024

Proposed Changes

This uses event callbacks to allow decoupling of Consumers (including subclasses) and the RabbitMQ IModel interface. We will now be able to simplify the test suite and reduce the total execution time. The next step will be to remove all usage of IModel outside of the RabbitMQBroker class.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.40%. Comparing base (36299ba) to head (2dc533b).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/SmiServices/Common/Messaging/Consumer.cs 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2068      +/-   ##
==========================================
- Coverage   65.48%   65.40%   -0.08%     
==========================================
  Files         181      182       +1     
  Lines        6530     6536       +6     
  Branches      963      966       +3     
==========================================
- Hits         4276     4275       -1     
- Misses       1963     1967       +4     
- Partials      291      294       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm marked this pull request as ready for review December 30, 2024 14:42
@rkm rkm merged commit ab15b01 into main Dec 30, 2024
9 of 10 checks passed
@rkm rkm deleted the refactor-consumers branch December 30, 2024 14:43
@rkm rkm requested a review from jas88 December 30, 2024 14:43
Copy link
Member

@jas88 jas88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good stuff - are you working on that next step this week? I'm going to try to get some divorce stuff out of the way this week before we officially start back next Monday.

@rkm
Copy link
Member Author

rkm commented Dec 30, 2024

I'll spend a bit more time on it today, but probably won't be able to finish it off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants