Skip to content

Commit

Permalink
remove unnecessary TestFixture annotations
Browse files Browse the repository at this point in the history
  • Loading branch information
rkm committed Jan 2, 2025
1 parent 0728584 commit 18a32ee
Show file tree
Hide file tree
Showing 31 changed files with 11 additions and 31 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace SmiServices.IntegrationTests.Common.MongoDB;

[TestFixture, RequiresMongoDb]
[RequiresMongoDb]
public class MongoQueryParserTests
{
private readonly ILogger _logger = LogManager.GetCurrentClassLogger();
Expand Down
1 change: 0 additions & 1 deletion tests/SmiServices.IntegrationTests/Common/OptionsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
namespace SmiServices.IntegrationTests.Common;

//TODO: Rework these tests. We should assert that every option in GlobalOptions has an entry in default.yaml. Non-required options should be present with a comment
[TestFixture]
public class OptionsTests
{
[TestCase]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

namespace SmiServices.IntegrationTests.Microservices.CohortPackager;

[TestFixture, RequiresMongoDb, RequiresRabbit]
[RequiresMongoDb, RequiresRabbit]
public class CohortPackagerHostTest
{
private readonly TestDateTimeProvider _dateTimeProvider = new();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace SmiServices.IntegrationTests.Microservices.DicomTagReader;

[TestFixture, RequiresRabbit]
[RequiresRabbit]
public class DicomTagReaderHostTests
{
private readonly DicomTagReaderTestHelper _helper = new();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace SmiServices.IntegrationTests.Microservices.DicomTagReader.Messaging;

[TestFixture, RequiresRabbit]
[RequiresRabbit]
public class DicomTagReaderConsumerTests
{
private readonly DicomTagReaderTestHelper _helper = new();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace SmiServices.IntegrationTests.Microservices.DicomTagReader;

//TODO Some of these can be tested without RabbitMQ
[TestFixture, RequiresRabbit]
[RequiresRabbit]
public class TagReaderTests
{
private readonly DicomTagReaderTestHelper _helper = new();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@

namespace SmiServices.IntegrationTests.Microservices.IdentifierMapper;

[TestFixture]
[RequiresRelationalDb(DatabaseType.MicrosoftSQLServer)]
public class IdentifierMapperTests : DatabaseTests
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace SmiServices.IntegrationTests.Microservices.IsIdentifiable;

[TestFixture, RequiresRabbit]
[RequiresRabbit]
public class IsIdentifiableHostTests
{
[OneTimeSetUp]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

namespace SmiServices.IntegrationTests.Microservices.MongoDBPopulator;

[TestFixture, RequiresMongoDb]
[RequiresMongoDb]
public class MongoDbAdapterTests
{
private MongoDbPopulatorTestHelper _helper = null!;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

namespace SmiServices.IntegrationTests.Microservices.MongoDBPopulator;

[TestFixture, RequiresMongoDb, RequiresRabbit]
[RequiresMongoDb, RequiresRabbit]
public class MongoDbPopulatorHostTests
{
private MongoDbPopulatorTestHelper _helper = null!;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

namespace SmiServices.IntegrationTests.Microservices.MongoDBPopulator.Processing;

[TestFixture, RequiresMongoDb]
[RequiresMongoDb]
public class ImageMessageProcessorTests
{
private MongoDbPopulatorTestHelper _helper = null!;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace SmiServices.IntegrationTests.Microservices.MongoDBPopulator.Processing;

[TestFixture, RequiresMongoDb]
[RequiresMongoDb]
public class MessageProcessorTests
{
private MongoDbPopulatorTestHelper _helper = null!;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

namespace SmiServices.IntegrationTests.Microservices.MongoDBPopulator.Processing;

[TestFixture, RequiresMongoDb]
[RequiresMongoDb]
public class SeriesMessageProcessorTests
{
private MongoDbPopulatorTestHelper _helper = null!;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ namespace SmiServices.UnitTests.Applications.DicomDirectoryProcessor;
/// <summary>
/// Unit tests for AccessionDirectoryLister
/// </summary>
[TestFixture]
public class AccessionDirectoryListerTest
{
[OneTimeSetUp]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ namespace SmiServices.UnitTests.Applications.DicomDirectoryProcessor;
/// <summary>
/// Unit tests for BasicDicomDirectoryFinder
/// </summary>
[TestFixture]
public class DicomDirectoryFinderTest
{
[OneTimeSetUp]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

namespace SmiServices.UnitTests.Applications.DicomDirectoryProcessor;

[TestFixture]
public class PacsDirectoryFinderTests
{
[OneTimeSetUp]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ namespace SmiServices.UnitTests.Applications.DicomDirectoryProcessor;
/// <summary>
/// Unit tests for ZipDicomDirectoryFinder
/// </summary>
[TestFixture]
public class ZipDicomDirectoryFinderTests
{
[OneTimeSetUp]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

namespace SmiServices.UnitTests.Common.Messages;

[TestFixture]
public class MessageHeaderTest
{
private readonly Dictionary<string, object> _testProps = new()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

namespace SmiServices.UnitTests.Common.MongoDB;

[TestFixture]
public class MongoDocumentHeadersTests
{
[OneTimeSetUp]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

namespace SmiServices.UnitTests.Common.MongoDB;

[TestFixture]
public class MongoModalityGroupsTests
{
[Test]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

namespace SmiServices.UnitTests.Microservices.CohortPackager.Execution.ExtractJobStorage;

[TestFixture]
public class ExtractJobInfoTest
{
private readonly TestDateTimeProvider _dateTimeProvider = new();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
namespace SmiServices.UnitTests.Microservices.CohortPackager.Execution.ExtractJobStorage;


[TestFixture]
public class ExtractJobStoreTest
{
#region Fixture Methods
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

namespace SmiServices.UnitTests.Microservices.CohortPackager.Execution.ExtractJobStorage.MongoDB;

[TestFixture]
public class MongoExtractJobInfoExtensionsTest
{
private readonly DateTimeProvider _dateTimeProvider = new TestDateTimeProvider();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

namespace SmiServices.UnitTests.Microservices.CohortPackager.Execution.ExtractJobStorage.MongoDB;

[TestFixture]
public class MongoExtractJobStoreTest
{
private const string ExtractionDatabaseName = "testExtraction";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

namespace SmiServices.UnitTests.Microservices.CohortPackager.Execution.ExtractJobStorage.MongoDB.ObjectModel;

[TestFixture]
public class MongoCompletedExtractJobDocTest
{
private static readonly DateTimeProvider _dateTimeProvider = new TestDateTimeProvider();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

namespace SmiServices.UnitTests.Microservices.CohortPackager.Execution.ExtractJobStorage.MongoDB.ObjectModel;

[TestFixture]
public class MongoExpectedFilesDocTest
{
private readonly DateTimeProvider _dateTimeProvider = new TestDateTimeProvider();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

namespace SmiServices.UnitTests.Microservices.CohortPackager.Execution.ExtractJobStorage.MongoDB.ObjectModel;

[TestFixture]
public class MongoExtractJobDocTest
{
private readonly DateTimeProvider _dateTimeProvider = new TestDateTimeProvider();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

namespace SmiServices.UnitTests.Microservices.CohortPackager.Execution.ExtractJobStorage.MongoDB.ObjectModel;

[TestFixture]
public class MongoExtractionMessageHeaderDocTest
{
#region Fixture Methods
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

namespace SmiServices.UnitTests.Microservices.CohortPackager.Execution.ExtractJobStorage.MongoDB.ObjectModel;

[TestFixture]
public class MongoFileStatusDocTest
{
private readonly TestDateTimeProvider _dateTimeProvider = new();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

namespace SmiServices.UnitTests.Microservices.CohortPackager.Execution.JobProcessing;

[TestFixture]
public class ExtractJobWatcherTest
{
#region Fixture Methods
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

namespace SmiServices.UnitTests.Microservices.MongoDbPopulator.Execution.Processing;

[TestFixture]
public class ImageMessageProcessorTests_NoMongo
{
private GlobalOptions _testOptions = null!;
Expand Down

0 comments on commit 18a32ee

Please sign in to comment.