Cmd add modality #340
Cmd add modality #340
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| var study = template.Tables.Single(t => t.TableName.Equals(StudyTable)); | ||
| var series = template.Tables.Single(t => t.TableName.Equals(SeriesTable)); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
|
|
||
| var study = template.Tables.Single(t => t.TableName.Equals(StudyTable)); | ||
| var series = template.Tables.Single(t => t.TableName.Equals(SeriesTable)); | ||
| var image = template.Tables.Single(t => t.TableName.Equals(ImageTable)); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
| private readonly DiscoveredDatabase _live; | ||
| private readonly LoadMetadata _lmd; | ||
| private readonly string _prefix; | ||
| private ExecuteCommandCreateNewImagingDatasetSuite _schemaCreationCommand; |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity
| catch (Exception ex) | ||
| { | ||
| SetImpossible($"Could not get single live server from the LoadMetadata {lmd} :" + ex); | ||
| return; | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
| if (modality.EndsWith("_")) | ||
| { | ||
| _prefix = modality; | ||
| } | ||
| else | ||
| { | ||
| _prefix = modality + "_"; | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity
| foreach (var n in new[] { StudyTable, SeriesTable, ImageTable }) | ||
| { | ||
| if (template.Tables.Any(t => t.TableName.Equals(n))) | ||
| { | ||
| SetImpossible($"Template did not contain an expected table name: {n}. Table names in template were {string.Join(",", template.Tables.Select(t => t.TableName))}"); | ||
| return; | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where
| } | ||
| } | ||
|
|
||
| var study = template.Tables.Single(t => t.TableName.Equals(StudyTable)); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
Add a function to populate a new modality