Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Added support for -nd flag. #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iikercosta
Copy link

SIPp v3.6.1 supports the flag -nd but this project does not. With this commit pysipp supports the -nd flag through the keyword param no_default.

-nd              : No Default. Disable all default behavior of SIPp which are the following:
                      - On UDP retransmission timeout, abort the call by sending a BYE or a CANCEL
                      - On receive timeout with no ontimeout attribute, abort the call by sending
                        a BYE or a CANCEL
                      - On unexpected BYE send a 200 OK and close the call
                      - On unexpected CANCEL send a 200 OK and close the call
                      - On unexpected PING send a 200 OK and continue the call
                      - On any other unexpected message, abort the call by sending a BYE or a
                        CANCEL

@iikercosta
Copy link
Author

An example of use for using this extra argument could be the following
pysipp.client(destaddr=('10.10.8.88', 5060), no_default=True)()

@goodboy
Copy link
Member

goodboy commented Dec 18, 2022

@iikercosta iikercosta, apologies for this sitting so long.

It looks good to me but not sure if any additional test helps here; i'm thinking no since it'd just be testing our kwargs -> cli flags machinery?

Can you rebase this to latest master so we can see CI run as well?

@iikercosta
Copy link
Author

Yeah, only affects cli arguments. Already merged the lastest master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants