Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.1.0 release #54

Merged
merged 8 commits into from
Dec 24, 2020
Merged

0.1.0 release #54

merged 8 commits into from
Dec 24, 2020

Conversation

goodboy
Copy link
Member

@goodboy goodboy commented Jul 5, 2019 •
edited
Loading

An attempt at getting #42 going!

Things to do after this gets merged:

Note this will be our first release in general but our last supporting python 2.7. Once this lands and the package has been tested by all I'll be moving forward with stripping out py2.7 hindrances which should get us a bunch of cool stuff going forward!

@goodboy goodboy requested review from vodik and wdoekes July 5, 2019 16:47
@goodboy
Copy link
Member Author

goodboy commented Jul 5, 2019

Draft release is up on test.pypi.

Can everyone try a download and test of it:
pip install --index-url https://test.pypi.org/simple/ --no-deps pysipp

Note you'll have to install all the deps manually with pip since most of them aren't hosted on the test server.

ping @y-luis @luismartingil

@goodboy goodboy mentioned this pull request Jul 5, 2019
Open
@goodboy
Add some additional logdir passing tests
d38686a 
Relates to #20
@goodboy
Assign kwargs to Scenario.defaults at creation
49d3881 
The `defaults` kwarg to `pysipp.agent.Scenario` isn't used so just drop
it and instead comb through provided `kwargs` and pop out values passed
by the user into `pysipp.agent.Scenario.defaults` making these the "new"
defaults applied to agents. Also, rename the default settings dicts more
explicitly.

Resolves #20
@goodboy
Add official release stamp and be looser on pluggy version
4b51ec7
@goodboy
Copy link
Member Author

goodboy commented Jul 24, 2019

@vodik @wdoekes any thoughts or should I just get this moving?

Also what does everyone think for a changelog/release system?
The pytest bois i work with all use towncrier but I'm open to trying whatever the hip new thing is.

@wdoekes
Copy link
Member

wdoekes commented Jul 25, 2019

Sorry, no time to review these weeks.

Just get it moving :)

One can always make a new release if things are amiss.

@goodboy
Raise ValueError on non-tuple assignment
0dc9dbc 
These fancy tuple-attribute-properties are supposed to be strictly
assigned tuple types; let's enforce that.

Resolves #12
@goodboy
Further fixes
2652f52 
As per the change for #20, handle the case where the user passes in
a `defaults` kwarg to `pysipp.scenario` and use it override the normal
template. To fully solve #12 also support assignment of `None` which
results in the tuple attribute taking a value of `(None, None)`
implicitly.
@goodboy
Doc tweak
1c56602
@goodboy
Use latest official sipp release in CI
36f0d0b
@goodboy
Moderninze setup.py to new PyPa standards
64850d1
@goodboy goodboy mentioned this pull request Jul 30, 2019
Open
@goodboy
Copy link
Member Author

goodboy commented Dec 24, 2020

Lol I guess I dropped the ball on this one.

Did anyone ever test the test server?

I'm happy to merge and upload.

Lurkers need to yell at us here!

@goodboy goodboy merged commit f1c2e5d into master Dec 24, 2020
@goodboy goodboy deleted the 0.1.0_release branch December 24, 2020 14:54
@goodboy
Copy link
Member Author

goodboy commented Dec 24, 2020

https://pypi.org/project/pysipp/

If it blows up open an issue and we'll make another minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vodik vodik Awaiting requested review from vodik

@wdoekes wdoekes Awaiting requested review from wdoekes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goodboy @wdoekes